psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

fix(settings): drop stale 3rd arg from RMM delete_lookup calls (MAPPS-224) #237

Merged
vas2000-work merged 1 commit from fix/mapps-rmm-delete-lookup-arity into main 2026-06-17 02:09:18 +02:00
Conversation 0 Commits 1 Files changed 1 +3 -3
vas2000-work commented 2026-06-17 02:08:04 +02:00
Owner
Copy link

Fixes the long-standing check.yml compile failure (MAPPS-224, red since the MAPPS-189 + MAPPS-199 merges). delete_lookup is (id, base) after MAPPS-189 moved confirmation into the modal, but the three RMM call sites still passed a 3rd label arg -> E0061 x3 on cargo check --target wasm32-unknown-unknown. Removed the unused arg at all three sites.

Verified in-container (just pre-commit): fmt + clippy -D warnings + wasm check + unit tests all green.

Fixes MAPPS-224 (and the follow-on CI-failure dups MAPPS-226/227/228).

Fixes the long-standing check.yml compile failure (MAPPS-224, red since the MAPPS-189 + MAPPS-199 merges). delete_lookup is (id, base) after MAPPS-189 moved confirmation into the modal, but the three RMM call sites still passed a 3rd label arg -> E0061 x3 on `cargo check --target wasm32-unknown-unknown`. Removed the unused arg at all three sites. Verified in-container (`just pre-commit`): fmt + clippy -D warnings + wasm check + unit tests all green. Fixes MAPPS-224 (and the follow-on CI-failure dups MAPPS-226/227/228).
fix(settings): drop stale 3rd arg from RMM delete_lookup calls
All checks were successful
Check / clippy + fmt + tests (pull_request) Successful in 1m8s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
e385741e6d 
main has not compiled (check.yml red, MAPPS-224) since the RMM settings
UI (MAPPS-199) and the ConfirmDialog refactor (MAPPS-189) merged
together: MAPPS-189 reduced delete_lookup to (id, base) because the
styled SettingFormModal now handles confirmation, but the three RMM call
sites (connections, device-mappings, alert-rules) still pass the old 3rd
label argument, so cargo check --target wasm32 failed with E0061 x3.

Drop the unused label argument at all three call sites. Verified
in-container (just pre-commit): fmt + clippy -D warnings + wasm check +
unit tests all green.

#MAPPS-224

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vas2000-work deleted branch fix/mapps-rmm-delete-lookup-arity 2026-06-17 02:09:18 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!237
No description provided.