fix(settings): drop stale label arg from RMM delete_lookup calls #236

Closed

David wants to merge 0 commits from fix/MAPPS-228-rmm-delete-lookup-arity into main

David commented

2026-06-17 00:27:29 +02:00

Owner

MAPPS-189 (dd3485f) removed the kind/label parameter from delete_lookup when it moved destructive confirmation up-front into the styled ConfirmDialog, updating all settings call sites to the 2-arg form. The RMM admin UI (PR #211) was developed in parallel and added three new call sites (connections, device-mappings, alert-rules) still passing the old 3-arg form. Both merged to main, leaving 3-arg calls against the 2-arg definition, so cargo clippy/cargo check failed to compile (E0061) and check.yml went red on every push and PR.

The label was only ever used to build the native confirm prompt that no longer exists; the RMM delete error banners use hardcoded messages, so dropping the argument loses nothing. Removes the third argument at the three RMM call sites to match the current signature and the other ten lookup editors.

#MAPPS-228

MAPPS-189 (dd3485f) removed the `kind`/label parameter from `delete_lookup` when it moved destructive confirmation up-front into the styled ConfirmDialog, updating all settings call sites to the 2-arg form. The RMM admin UI (PR #211) was developed in parallel and added three new call sites (connections, device-mappings, alert-rules) still passing the old 3-arg form. Both merged to main, leaving 3-arg calls against the 2-arg definition, so `cargo clippy`/`cargo check` failed to compile (E0061) and check.yml went red on every push and PR. The label was only ever used to build the native confirm prompt that no longer exists; the RMM delete error banners use hardcoded messages, so dropping the argument loses nothing. Removes the third argument at the three RMM call sites to match the current signature and the other ten lookup editors. #MAPPS-228

David added 1 commit

2026-06-17 00:27:29 +02:00

fix(settings): drop stale label arg from RMM delete_lookup calls

Check / clippy + fmt + tests (pull_request) Successful in 2m8s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

e9de36c0ad

MAPPS-189 (dd3485f) removed the `kind`/label parameter from `delete_lookup` when it moved destructive confirmation up-front into the styled ConfirmDialog, updating all settings call sites to the 2-arg form. The RMM admin UI (PR #211) was developed in parallel and added three new call sites (connections, device-mappings, alert-rules) still passing the old 3-arg form. Both merged to main, leaving 3-arg calls against the 2-arg definition, so `cargo clippy`/`cargo check` failed to compile (E0061) and check.yml went red on every push and PR.

The label was only ever used to build the native confirm prompt that no longer exists; the RMM delete error banners use hardcoded messages, so dropping the argument loses nothing. Removes the third argument at the three RMM call sites to match the current signature and the other ten lookup editors.

#MAPPS-228