fix(settings): drop extra arg from RMM delete_lookup calls #235

Closed

David wants to merge 0 commits from fix/mapps-226-delete-lookup-extra-arg into main

David commented

2026-06-17 00:21:09 +02:00

Owner

The RMM admin UI (connections, device mappings, alert rules) called delete_lookup with a third &'static str label argument, but the helper's signature is delete_lookup(id: &str, base: &str). This broke compilation with E0061 (3 arguments supplied, 2 expected) and failed clippy, the wasm check, and tests in check.yml. The label was redundant: each call site already names the entity in its error message ("Could not delete connection", etc.). Remove the third argument from all three call sites to match the function signature and the other ten lookup-editor call sites.

#MAPPS-226

The RMM admin UI (connections, device mappings, alert rules) called `delete_lookup` with a third `&'static str` label argument, but the helper's signature is `delete_lookup(id: &str, base: &str)`. This broke compilation with E0061 (3 arguments supplied, 2 expected) and failed clippy, the wasm check, and tests in check.yml. The label was redundant: each call site already names the entity in its error message ("Could not delete connection", etc.). Remove the third argument from all three call sites to match the function signature and the other ten lookup-editor call sites. #MAPPS-226

David added 1 commit

2026-06-17 00:21:09 +02:00

fix(settings): drop extra arg from RMM delete_lookup calls

Check / clippy + fmt + tests (pull_request) Successful in 2m22s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

c0f78fea83

The RMM admin UI (connections, device mappings, alert rules) called `delete_lookup` with a third `&'static str` label argument, but the helper's signature is `delete_lookup(id: &str, base: &str)`. This broke compilation with E0061 (3 arguments supplied, 2 expected) and failed clippy, the wasm check, and tests in check.yml. The label was redundant: each call site already names the entity in its error message ("Could not delete connection", etc.). Remove the third argument from all three call sites to match the function signature and the other ten lookup-editor call sites.

#MAPPS-226