fix(rmm): drop extra arg from delete_lookup RMM call sites #233

Closed

David wants to merge 0 commits from chore/checks-workflow-4d9d4bf3 into main

David commented

2026-06-16 23:57:02 +02:00

Owner

The RMM admin UI (#211) and the timesheet approvals UI (#207) merged independently. The RMM branch was written against an older delete_lookup(id, base, label) signature, but the merged delete_lookup takes only (id, base). The three RMM delete call sites (connections, device-mappings, alert-rules) passed a vestigial label string, which broke cargo clippy --all-targets -- -D warnings (E0061) and the lib/test builds on main.

Remove the unused third argument so the call sites match the function signature and the other ten delete_lookup callers. The human-readable label was already hardcoded in each surrounding error message, so no behavior changes.

#MAPPS-224

The RMM admin UI (#211) and the timesheet approvals UI (#207) merged independently. The RMM branch was written against an older `delete_lookup(id, base, label)` signature, but the merged `delete_lookup` takes only `(id, base)`. The three RMM delete call sites (connections, device-mappings, alert-rules) passed a vestigial label string, which broke `cargo clippy --all-targets -- -D warnings` (E0061) and the lib/test builds on `main`. Remove the unused third argument so the call sites match the function signature and the other ten `delete_lookup` callers. The human-readable label was already hardcoded in each surrounding error message, so no behavior changes. #MAPPS-224

David added 1 commit

2026-06-16 23:57:02 +02:00

fix(rmm): drop extra arg from delete_lookup RMM call sites

Check / clippy + fmt + tests (pull_request) Successful in 2m58s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

d16958f9d4

The RMM admin UI (#211) and the timesheet approvals UI (#207) merged independently. The RMM branch was written against an older `delete_lookup(id, base, label)` signature, but the merged `delete_lookup` takes only `(id, base)`. The three RMM delete call sites (connections, device-mappings, alert-rules) passed a vestigial label string, which broke `cargo clippy --all-targets -- -D warnings` (E0061) and the lib/test builds on `main`.

Remove the unused third argument so the call sites match the function signature and the other ten `delete_lookup` callers. The human-readable label was already hardcoded in each surrounding error message, so no behavior changes.

#MAPPS-224