chore(common): bump the common submodule to 4de5dfa and add a default recipe #118

Merged
David merged 1 commit from chore/GOV-45-update-common-submodule into main 2026-08-08 02:33:39 +02:00
Owner

Bumps the common submodule gitlink from d3a51c8 to 4de5dfa (current psa-systems/common main) and adds the default recipe that common's PC-12 documentation requires. Part of the cross-repo sync tracked in GOV-45.

What the new pin brings in: the reusable check workflow's runner-label switch to RUNS_ON_OPENSUSE_DEV_LATEST, the nu line-continuation fix in build-docker-export, a docker compose build app step so pre-commit stops reusing a stale dev image after a Dockerfile change, and the new check-tree-ownership guard that both pre-commit variants now run at the end.

Adopted: a default recipe, kept first in the file, plus set allow-duplicate-recipes := true so it can shadow the imported one. just picks the default recipe by source order in the root justfile and never selects an imported one, so common's default was never eligible here. Confirmed before the change: bare just in this repo failed with error: Justfile contains no default recipe. It now lists the recipes.

Already adopted, no change needed: release_layout := "virtual-workspace" (the root manifest is virtual and carries [workspace.package] version), test_args := "--lib", and dev_extra_volumes := "dev-vervain-server-data". The extra-volume list is complete: compose.dev.yml declares only cargo-target and vervain-data as volumes, and vervain-private is a network, which dev-clean does not manage. The reusable check workflow's compile_step: check / test_args: --lib / cache: true inputs are already wired in .forgejo/workflows/check.yml.

Verification: just pre-commit passes on the new pin (fmt, clippy, build, 482 tests, and check-tree-ownership reports the working tree fully owned by the host user).

#GOV-45

Bumps the `common` submodule gitlink from `d3a51c8` to `4de5dfa` (current `psa-systems/common` `main`) and adds the `default` recipe that common's PC-12 documentation requires. Part of the cross-repo sync tracked in GOV-45. What the new pin brings in: the reusable check workflow's runner-label switch to `RUNS_ON_OPENSUSE_DEV_LATEST`, the nu line-continuation fix in `build-docker-export`, a `docker compose build app` step so `pre-commit` stops reusing a stale dev image after a Dockerfile change, and the new `check-tree-ownership` guard that both `pre-commit` variants now run at the end. Adopted: a `default` recipe, kept first in the file, plus `set allow-duplicate-recipes := true` so it can shadow the imported one. just picks the default recipe by source order in the root justfile and never selects an imported one, so common's `default` was never eligible here. Confirmed before the change: bare `just` in this repo failed with `error: Justfile contains no default recipe.` It now lists the recipes. Already adopted, no change needed: `release_layout := "virtual-workspace"` (the root manifest is virtual and carries `[workspace.package] version`), `test_args := "--lib"`, and `dev_extra_volumes := "dev-vervain-server-data"`. The extra-volume list is complete: `compose.dev.yml` declares only `cargo-target` and `vervain-data` as volumes, and `vervain-private` is a network, which `dev-clean` does not manage. The reusable check workflow's `compile_step: check` / `test_args: --lib` / `cache: true` inputs are already wired in `.forgejo/workflows/check.yml`. Verification: `just pre-commit` passes on the new pin (fmt, clippy, build, 482 tests, and `check-tree-ownership` reports the working tree fully owned by the host user). #GOV-45
chore(common): bump the common submodule to 4de5dfa and add a default recipe
All checks were successful
Check / check (pull_request) Successful in 4m57s
Create release / Create release from merged PR (pull_request) Has been skipped
c93f99066a
Moves the `common` gitlink from d3a51c8 to 4de5dfa, picking up the runner-label switch to RUNS_ON_OPENSUSE_DEV_LATEST in the reusable check workflow, the nu line-continuation fix in `build-docker-export`, the `docker compose build app` step that stops `pre-commit` reusing a stale dev image after a Dockerfile change, and the `check-tree-ownership` guard now run at the end of both pre-commit variants.

Adds the `default` recipe that common's PC-12 documentation requires. just picks the default recipe by source order in the root justfile and never selects an imported one, so common's `default` was never eligible here and bare `just` failed with "Justfile contains no default recipe"; it now lists the recipes. `set allow-duplicate-recipes := true` is required so the local `default` can shadow the imported one.

`release_layout := "virtual-workspace"` and `dev_extra_volumes := "dev-vervain-server-data"` were already set, and `vervain-private` is a network rather than a volume, so the extra-volume list stays complete. `just pre-commit` passes on the new pin (fmt, clippy, build, 482 tests, ownership guard clean).

#GOV-45
David merged commit c194b4354a into main 2026-08-08 02:33:39 +02:00
David deleted branch chore/GOV-45-update-common-submodule 2026-08-08 02:33:39 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-server!118
No description provided.