psa-systems/vervain-apps
Watch
9
0
Fork
You've already forked vervain-apps
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(terminal): fill card height instead of fixed 360px #91

Merged
Claude-Run merged 1 commit from fix/VAPP-79-terminal-fill-card-height into main 2026-07-08 04:54:02 +02:00
Conversation 0 Commits 1 Files changed 1 +1 -1
Claude-Run commented 2026-07-08 04:53:00 +02:00
Member
Copy link

The Terminal pane host box was hard-pinned to a fixed 360px height, so the terminal stayed small no matter how tall the window was. Replace the fixed pixel height with the same rule the Desktop pane uses (height: 70vh; min-height: 360px) so the pane grows to fill the device-detail card. The xterm FitAddon plus ResizeObserver already re-fit cols/rows on host resize, so no terminal driver changes are needed; the box relative positioning is unchanged so the TermStatus overlay still centers over the resized host.

#VAPP-79

The Terminal pane host box was hard-pinned to a fixed 360px height, so the terminal stayed small no matter how tall the window was. Replace the fixed pixel height with the same rule the Desktop pane uses (height: 70vh; min-height: 360px) so the pane grows to fill the device-detail card. The xterm FitAddon plus ResizeObserver already re-fit cols/rows on host resize, so no terminal driver changes are needed; the box relative positioning is unchanged so the TermStatus overlay still centers over the resized host. #VAPP-79
fix(terminal): fill card height instead of fixed 360px
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 34s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
ef216df357 
The Terminal pane host box was hard-pinned to a fixed 360px height, so the terminal stayed small no matter how tall the window was. Replace the fixed pixel height with the same rule the Desktop pane uses (height: 70vh; min-height: 360px) so the pane grows to fill the device-detail card. The xterm FitAddon plus ResizeObserver already re-fit cols/rows on host resize, so no terminal driver changes are needed; the box relative positioning is unchanged so the TermStatus overlay still centers over the resized host.

#VAPP-79
Claude-Run deleted branch fix/VAPP-79-terminal-fill-card-height 2026-07-08 04:54:02 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-apps!91
No description provided.