fix(models): correct minisign wording in fetcher docs and guard it #85

Merged

Claude-Run merged 2 commits from fix/VAPP-72-agent-binaries-wording into main

2026-07-06 03:50:41 +02:00

Claude-Run commented

2026-07-06 03:49:38 +02:00

Member

Completeness sweep for the same wrong-scheme invariant fixed in the settings form: the AgentFetcherConfig doc comments still described the agent-binary signatures as minisign/minisig. The server verifies a detached age/XEdDSA signature against an age recipient key, so the docs now name that scheme.

Adds signing_scheme_guard, a test-only removal guard (mirroring enroll_guard) that scans the settings form and the models file and fails the build if any minisign wording reappears, enforcing the correction mechanically.

#VAPP-72

Completeness sweep for the same wrong-scheme invariant fixed in the settings form: the `AgentFetcherConfig` doc comments still described the agent-binary signatures as minisign/minisig. The server verifies a detached age/XEdDSA signature against an age recipient key, so the docs now name that scheme. Adds `signing_scheme_guard`, a test-only removal guard (mirroring `enroll_guard`) that scans the settings form and the models file and fails the build if any minisign wording reappears, enforcing the correction mechanically. #VAPP-72

Claude-Run added 2 commits

2026-07-06 03:49:38 +02:00

fix(settings): correct agent-binaries wording and show arch names 70dbfc114c

The Agent Binaries settings form carried inaccurate or unclear labels. This corrects them and always surfaces the human-readable CPU-architecture name for each Agent id.

- Rename the signing-key row from "Minisign public key" to "Signing public key (age)" and reword the help to name the age/XEdDSA scheme the server actually verifies. The implemented scheme is not minisign.
- Show the unit inline on the refresh-interval row: label is now "Refresh interval (seconds)".
- Add a static id -> architecture-name map mirroring `vervain_agent_proto::AgentId` and render "id (arch name)" beneath the Agent ids input so operators see e.g. "6 (Linux x86_64), 26 (Linux ARM64)". Unknown ids render "(unknown)". The stored/submitted value stays the numeric ids.
- Reword the Refresh-now result to make server storage explicit: "Stored N agent binary/binaries on the server, M failed."

Adds unit tests locking the id -> name mapping, the unknown fallback, and the display formatting.

#VAPP-72

fix(models): correct minisign wording in fetcher docs and guard it

Check / fmt + clippy + build + tests (pull_request) Successful in 33s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

319c5d1029

Completeness sweep for the same wrong-scheme invariant fixed in the settings form: the `AgentFetcherConfig` doc comments still described the agent-binary signatures as minisign/minisig. The server verifies a detached age/XEdDSA signature against an age recipient key, so the docs now name that scheme.

Adds `signing_scheme_guard`, a test-only removal guard (mirroring `enroll_guard`) that scans the settings form and the models file and fails the build if any minisign wording reappears, enforcing the correction mechanically.

#VAPP-72