psa-systems/vervain-apps
Watch
9
0
Fork
You've already forked vervain-apps
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(new-device): emit --install-type system, not removed --system flag #83

Merged
Claude-Run merged 1 commit from fix/VAPP-71-install-type-flag into main 2026-07-06 00:26:24 +02:00
Conversation 0 Commits 1 Files changed 1 +42 -2
Claude-Run commented 2026-07-06 00:25:22 +02:00
Member
Copy link

The "+ New Device" install snippets passed --system to vervain-agent install, but VA-84 removed that boolean flag in favour of --install-type <system|user>. clap rejects the unknown argument, so every copy-pasted one-liner or scp snippet failed at the first step with unexpected argument '--system'. Both call sites in new_device.rs now emit the explicit --install-type system (system is still the default, so intent is unchanged) matching the CLI's own documented example. Added a test module asserting both snippets use --install-type system and contain no --system, so the stale flag cannot reappear.

#VAPP-71

The "+ New Device" install snippets passed --system to `vervain-agent install`, but VA-84 removed that boolean flag in favour of --install-type <system|user>. clap rejects the unknown argument, so every copy-pasted one-liner or scp snippet failed at the first step with `unexpected argument '--system'`. Both call sites in new_device.rs now emit the explicit `--install-type system` (system is still the default, so intent is unchanged) matching the CLI's own documented example. Added a test module asserting both snippets use --install-type system and contain no --system, so the stale flag cannot reappear. #VAPP-71
fix(new-device): emit --install-type system, not removed --system flag
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 43s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
709b7de39b 
The "+ New Device" install snippets passed --system to `vervain-agent install`, but VA-84 removed that boolean flag in favour of --install-type <system|user>. clap rejects the unknown argument, so every copy-pasted one-liner or scp snippet failed at the first step with `unexpected argument '--system'`. Both call sites in new_device.rs now emit the explicit `--install-type system` (system is still the default, so intent is unchanged) matching the CLI's own documented example. Added a test module asserting both snippets use --install-type system and contain no --system, so the stale flag cannot reappear.

#VAPP-71
Claude-Run deleted branch fix/VAPP-71-install-type-flag 2026-07-06 00:26:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-apps!83
No description provided.