feat(api): read canonical INFISICAL_ADDRESS for the readiness probe (GOV-50) #515

Merged

nrupard merged 1 commit from feat/PMS-768-canonical-infisical-address into main

2026-08-13 19:43:45 +02:00

nrupard commented

2026-08-13 18:07:14 +02:00

Owner

Converges mokosh-server's runtime Infisical var onto the canonical set (GOV-50 / PMS-768).

Change

mokosh-server's only runtime Infisical read is the readiness probe (src/api/router.rs); the full InfisicalClient is dormant. The probe now reads INFISICAL_ADDRESS, falling back to the legacy INFISICAL_BASE_URL for one release (expand). The readiness integration test blanks both names.

Not touched

INFISICAL_ENVIRONMENT (read only by the bootstrap CLI, not the runtime) and the dormant InfisicalClient stay as-is.

Deploy note

The container var (compose.dev.yml, and the docker repo c-01/nc-01 compose-secrets.yml) is still INFISICAL_BASE_URL; the fallback keeps it working. Migrate it to INFISICAL_ADDRESS (a SOPS edit for the deploy) when ready, then drop the fallback (contract).

Verification

No local cargo on this box; CI runs fmt/clippy/tests. The probe's blank-is-unconfigured unit tests are value-based (not env-name), so unaffected; the readiness integration test now blanks both names.

Converges mokosh-server's runtime Infisical var onto the canonical set (GOV-50 / PMS-768). ## Change mokosh-server's only runtime Infisical read is the readiness probe (`src/api/router.rs`); the full `InfisicalClient` is dormant. The probe now reads `INFISICAL_ADDRESS`, falling back to the legacy `INFISICAL_BASE_URL` for one release (expand). The readiness integration test blanks both names. ## Not touched `INFISICAL_ENVIRONMENT` (read only by the bootstrap CLI, not the runtime) and the dormant `InfisicalClient` stay as-is. ## Deploy note The container var (compose.dev.yml, and the docker repo c-01/nc-01 `compose-secrets.yml`) is still `INFISICAL_BASE_URL`; the fallback keeps it working. Migrate it to `INFISICAL_ADDRESS` (a SOPS edit for the deploy) when ready, then drop the fallback (contract). ## Verification No local cargo on this box; CI runs fmt/clippy/tests. The probe's blank-is-unconfigured unit tests are value-based (not env-name), so unaffected; the readiness integration test now blanks both names.

nrupard added 1 commit

2026-08-13 18:07:15 +02:00

feat(api): read canonical INFISICAL_ADDRESS for the readiness probe (GOV-50)

Check / fmt + clippy + build + tests (pull_request) Successful in 2m16s

Details

E2E / Playwright against staging (pull_request) Successful in 2m17s

Details

Integration / integration tests (pull_request) Successful in 6m30s

Details

Create release / Gate (release-branch merges only) (pull_request) Successful in 0s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

9e3d11481e

The Infisical readiness probe now reads the canonical INFISICAL_ADDRESS, falling back to the legacy INFISICAL_BASE_URL for one release (expand, GOV-50 / PMS-768). The readiness integration test blanks both names. Deploy/dev config can then migrate the container var from INFISICAL_BASE_URL to INFISICAL_ADDRESS with no downtime; drop the fallback afterward (contract). INFISICAL_ENVIRONMENT is untouched (bootstrap CLI only, not the runtime).

#PMS-768

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>