psa-systems/mokosh-server
Watch
9
0
Fork
You've already forked mokosh-server
 1
Code Issues Pull requests Projects Releases 10 Packages Wiki Activity Actions

test(e2e): expect inline "Company is required." copy on new-ticket form (PMS-535) #394

Merged
Claude-Run merged 1 commit from fix/PMS-535-company-required-copy into main 2026-06-28 02:30:32 +02:00
Conversation 0 Commits 1 Files changed 1 +6 -3
Claude-Run commented 2026-06-28 02:21:24 +02:00
Member
Copy link

The form-validation spec asserted the missing-company error read "Please pick a company first." from the old form-level banner. MAPPS-322 in the mokosh-apps SPA routed that error into the CompanyPicker's own inline slot (it now takes an error: prop), so it renders via the shared Rule::Required message as "Company is required." - matching the Title/Description copy. The deployed SPA no longer emits the old string anywhere, so line 63 timed out at 15s and failed all three browsers. Update the expected text and the now-stale comment to match the inline-slot behaviour.

#PMS-535

The form-validation spec asserted the missing-company error read "Please pick a company first." from the old form-level banner. MAPPS-322 in the mokosh-apps SPA routed that error into the CompanyPicker's own inline slot (it now takes an `error:` prop), so it renders via the shared `Rule::Required` message as "Company is required." - matching the Title/Description copy. The deployed SPA no longer emits the old string anywhere, so line 63 timed out at 15s and failed all three browsers. Update the expected text and the now-stale comment to match the inline-slot behaviour. #PMS-535
test(e2e): expect inline "Company is required." copy on new-ticket form (PMS-535)
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 2m1s
Details
E2E / Playwright against staging (pull_request) Successful in 46s
Details
Integration / integration tests (pull_request) Successful in 8m43s
Details
Create release / Gate (release-branch merges only) (pull_request) Successful in 0s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
7c400b9e1a 
The form-validation spec asserted the missing-company error read "Please pick a company first." from the old form-level banner. MAPPS-322 in the mokosh-apps SPA routed that error into the CompanyPicker's own inline slot (it now takes an `error:` prop), so it renders via the shared `Rule::Required` message as "Company is required." - matching the Title/Description copy. The deployed SPA no longer emits the old string anywhere, so line 63 timed out at 15s and failed all three browsers. Update the expected text and the now-stale comment to match the inline-slot behaviour.

#PMS-535
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-server!394
No description provided.