chore(auth): drop stale crates/mokosh-auth-http comment refs (PMS-295) #389

Merged

Claude-Run merged 2 commits from feat/PMS-295-remove-mokosh-auth-mechanism-2 into main

2026-06-26 16:32:50 +02:00

Claude-Run commented

2026-06-26 16:22:39 +02:00

Member

Two doc comments still pointed at crates/mokosh-auth-http (deleted in the previous commit): the lettre dependency note in Cargo.toml and the rate_limit.rs "Modelled on" attribution. Remove the dead-path references; comment-only, no behaviour change.

#PMS-295

Claude-Run added 2 commits

2026-06-26 16:22:39 +02:00

feat(auth): remove mokosh-auth; bunyip-as-OP is the sole OP (PMS-295) 1c619d74f2

Tear out mokosh-auth (mechanism 2, mokosh's own OIDC OP) so bunyip-as-OP becomes the only OP. The server now authenticates exclusively via the bunyip Resource-Server path (OIDC_ISSUER/OIDC_AUDIENCE) and the legacy HS256 cookie path; it holds no signing key and exposes no /oauth2/* surface. PMS-291 established that nothing observed actually used mechanism 2.

Workspace + wiring: drop the crates/mokosh-auth* members (core/crypto/storage/oidc/federation/http/umbrella), remove the host deps, and delete the host-side hooks - the try_bootstrap_sso/SsoSetup bootstrap and sso_router merge in main.rs, the AtJwtVerifier param + with_at_jwt branch in router.rs/middleware.rs, and the at_jwt module. The bunyip RS path and legacy HS256 path are untouched.

Legacy TOTP stays working: the RFC 6238 TOTP + MFA recovery-code primitives that the legacy login flow consumed from mokosh-auth-crypto move into src/utils/totp.rs + src/utils/recovery.rs (host crate adds the sha1 dep). service.rs and tests/auth.rs point at the relocated modules; the unit tests pass unchanged.

Dead tooling removed: the clients-register subcommand (registered clients in mokosh_auth.oauth_clients) comes out of cli.rs and bin/mokosh-bootstrap.rs, and the register-* / ensure-oidc-keys justfile recipes plus scripts/gen-oidc-key.sh go with it. compose.dev.yml drops every MOKOSH_AUTH_* env (keeping OIDC_ISSUER/OIDC_AUDIENCE) and the ./secrets mount. CLAUDE.md and .env.example now describe bunyip-RS as the only OP.

The c-01/nc-01 compose-secrets + mokosh-server-secrets volume removal is the separate docker-repo follow-up (PR 2) and is not in this change.

#PMS-295

chore(auth): drop stale crates/mokosh-auth-http comment refs (PMS-295)

E2E / Playwright against staging (pull_request) Successful in 1m17s

Details

Check / fmt + clippy + build + tests (pull_request) Successful in 2m8s

Details

Integration / integration tests (pull_request) Successful in 10m1s

Details

Create release / Gate (release-branch merges only) (pull_request) Successful in 1s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

88b5a47945

Two doc comments still pointed at crates/mokosh-auth-http (deleted in the previous commit): the lettre dependency note in Cargo.toml and the rate_limit.rs "Modelled on" attribution. Remove the dead-path references; comment-only, no behaviour change.

#PMS-295