fix(checks): resolve migration prefix collision and qa-seed compile break

David commented

2026-06-17 00:10:24 +02:00

Owner

The check.yml gate failed at the migration-prefix uniqueness step: three concurrently-merged branches each picked prefix 051 (051_mileage_entries, 051_payments_amount_positive, 051_tax_rate_widen_column), and sqlx keys its _sqlx_migrations ledger on that prefix so a collision makes the applied version ambiguous (PMS-198). Renumber the two later-committed files to 052 (mileage) and 053 (tax_rate) by commit date, leaving 051_payments_amount_positive as 051, so apply order is preserved. Update the lone doc-comment reference in mileage_tracking/mod.rs to the new filename.

Past the prefix step, cargo check/clippy --all-targets also failed: src/modules/seed/qa.rs (the operator-triggered QA walkthrough seeder, server feature, in the default build) had not been updated when the project/time-tracking service mutations gained a trailing &AuditCtx argument (PMS-117) and CreateProjectRequest gained actual_end_date (PMS-361). Thread the existing AuditCtx::system(tid) context into create_project/create_project_phase/create_task/create_time_entry, build a system context from the tenant in the two lookup helpers (ensure_qa_work_type, ensure_qa_task_status), and set actual_end_date: None on both QA project specs (both projects are unfinished, so no real end date).

#PMS-377

The check.yml gate failed at the migration-prefix uniqueness step: three concurrently-merged branches each picked prefix 051 (051_mileage_entries, 051_payments_amount_positive, 051_tax_rate_widen_column), and sqlx keys its _sqlx_migrations ledger on that prefix so a collision makes the applied version ambiguous (PMS-198). Renumber the two later-committed files to 052 (mileage) and 053 (tax_rate) by commit date, leaving 051_payments_amount_positive as 051, so apply order is preserved. Update the lone doc-comment reference in mileage_tracking/mod.rs to the new filename. Past the prefix step, cargo check/clippy --all-targets also failed: src/modules/seed/qa.rs (the operator-triggered QA walkthrough seeder, server feature, in the default build) had not been updated when the project/time-tracking service mutations gained a trailing &AuditCtx argument (PMS-117) and CreateProjectRequest gained actual_end_date (PMS-361). Thread the existing AuditCtx::system(tid) context into create_project/create_project_phase/create_task/create_time_entry, build a system context from the tenant in the two lookup helpers (ensure_qa_work_type, ensure_qa_task_status), and set actual_end_date: None on both QA project specs (both projects are unfinished, so no real end date). #PMS-377

David added 1 commit

2026-06-17 00:10:24 +02:00

fix(checks): resolve migration prefix collision and qa-seed compile break

E2E / Playwright against staging (pull_request) Successful in 2m0s

Details

Check / fmt + clippy + compile + unit/doc tests (pull_request) Successful in 2m55s

Details

Integration / integration tests (pull_request) Successful in 7m49s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

92f67adf19

The check.yml gate failed at the migration-prefix uniqueness step: three concurrently-merged branches each picked prefix 051 (051_mileage_entries, 051_payments_amount_positive, 051_tax_rate_widen_column), and sqlx keys its _sqlx_migrations ledger on that prefix so a collision makes the applied version ambiguous (PMS-198). Renumber the two later-committed files to 052 (mileage) and 053 (tax_rate) by commit date, leaving 051_payments_amount_positive as 051, so apply order is preserved. Update the lone doc-comment reference in mileage_tracking/mod.rs to the new filename.

Past the prefix step, cargo check/clippy --all-targets also failed: src/modules/seed/qa.rs (the operator-triggered QA walkthrough seeder, server feature, in the default build) had not been updated when the project/time-tracking service mutations gained a trailing &AuditCtx argument (PMS-117) and CreateProjectRequest gained actual_end_date (PMS-361). Thread the existing AuditCtx::system(tid) context into create_project/create_project_phase/create_task/create_time_entry, build a system context from the tenant in the two lookup helpers (ensure_qa_work_type, ensure_qa_task_status), and set actual_end_date: None on both QA project specs (both projects are unfinished, so no real end date).

#PMS-377

vas2000-work commented

2026-06-17 02:13:58 +02:00

Owner

Superseded: the qa-seed compile fix + 051 migration-prefix de-duplication landed on main via #288 (kept 051_mileage_entries at 051, renumbered the two never-deployed migrations). Closing this duplicate.