chore(checks): renumber colliding 051 migrations and fix seed/qa.rs build

David commented

2026-06-16 23:58:33 +02:00

Owner

Three independently-merged branches each grabbed migration prefix 051 (051_mileage_entries.sql, 051_payments_amount_positive.sql, 051_tax_rate_widen_column.sql), which trips the PMS-198 prefix-uniqueness gate in check.yml. Renumber the two later-merged files by commit date so each prefix is unique again: payments (earliest) keeps 051, mileage becomes 052, tax-rate-widen becomes 053. Update the lone doc-comment reference in mileage_tracking/mod.rs to point at the new filename.

The same merges also left src/modules/seed/qa.rs uncompilable: service methods gained an AuditCtx parameter (create_project, create_project_phase, create_task, create_time_entry, create_work_type, create_task_status) and CreateProjectRequest gained an actual_end_date field, but the QA seeder was not updated. Thread the existing ctx into the four call sites that already have one in scope, build a local AuditCtx::system(tenant.get()) in the two helper methods that do not, and add actual_end_date: None to the two seed project literals. With these, the full check.yml suite (migration prefixes, fmt, clippy -D warnings, compile, unit + doc tests) is green.

#PMS-379

Three independently-merged branches each grabbed migration prefix `051` (`051_mileage_entries.sql`, `051_payments_amount_positive.sql`, `051_tax_rate_widen_column.sql`), which trips the PMS-198 prefix-uniqueness gate in check.yml. Renumber the two later-merged files by commit date so each prefix is unique again: payments (earliest) keeps `051`, mileage becomes `052`, tax-rate-widen becomes `053`. Update the lone doc-comment reference in mileage_tracking/mod.rs to point at the new filename. The same merges also left src/modules/seed/qa.rs uncompilable: service methods gained an `AuditCtx` parameter (`create_project`, `create_project_phase`, `create_task`, `create_time_entry`, `create_work_type`, `create_task_status`) and `CreateProjectRequest` gained an `actual_end_date` field, but the QA seeder was not updated. Thread the existing `ctx` into the four call sites that already have one in scope, build a local `AuditCtx::system(tenant.get())` in the two helper methods that do not, and add `actual_end_date: None` to the two seed project literals. With these, the full check.yml suite (migration prefixes, fmt, clippy -D warnings, compile, unit + doc tests) is green. #PMS-379

David added 1 commit

2026-06-16 23:58:33 +02:00

chore(checks): renumber colliding 051 migrations and fix seed/qa.rs build

Check / fmt + clippy + compile + unit/doc tests (pull_request) Successful in 2m55s

Details

E2E / Playwright against staging (pull_request) Successful in 1m11s

Details

Integration / integration tests (pull_request) Successful in 8m50s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

8540b9b2b5

Three independently-merged branches each grabbed migration prefix `051` (`051_mileage_entries.sql`, `051_payments_amount_positive.sql`, `051_tax_rate_widen_column.sql`), which trips the PMS-198 prefix-uniqueness gate in check.yml. Renumber the two later-merged files by commit date so each prefix is unique again: payments (earliest) keeps `051`, mileage becomes `052`, tax-rate-widen becomes `053`. Update the lone doc-comment reference in mileage_tracking/mod.rs to point at the new filename.

The same merges also left src/modules/seed/qa.rs uncompilable: service methods gained an `AuditCtx` parameter (`create_project`, `create_project_phase`, `create_task`, `create_time_entry`, `create_work_type`, `create_task_status`) and `CreateProjectRequest` gained an `actual_end_date` field, but the QA seeder was not updated. Thread the existing `ctx` into the four call sites that already have one in scope, build a local `AuditCtx::system(tenant.get())` in the two helper methods that do not, and add `actual_end_date: None` to the two seed project literals. With these, the full check.yml suite (migration prefixes, fmt, clippy -D warnings, compile, unit + doc tests) is green.

#PMS-379

vas2000-work commented

2026-06-17 02:13:57 +02:00

Owner

Superseded: the qa-seed compile fix + 051 migration-prefix de-duplication landed on main via #288 (kept 051_mileage_entries at 051, renumbered the two never-deployed migrations). Closing this duplicate.