psa-systems/mokosh-server
Watch
9
0
Fork
You've already forked mokosh-server
 1
Code Issues Pull requests Projects Releases 10 Packages Wiki Activity Actions

style: apply cargo fmt across modules and tests #172

Closed
David wants to merge 0 commits from david/fix/pms-230-cargo-fmt into main AGit
pull from: david/fix/pms-230-cargo-fmt
merge into: psa-systems:main
Conversation 1 Commits - Files changed 550 +128 -59
David commented 2026-06-11 14:35:53 +02:00
Owner
Copy link

Reformat src/ and tests/ to satisfy cargo fmt --check, which the check.yml CI job ran before clippy/compile and which failed (run #822) on import ordering and rustfmt line-wrapping. No functional changes; pure rustfmt output.

#PMS-230

Reformat src/ and tests/ to satisfy `cargo fmt --check`, which the check.yml CI job ran before clippy/compile and which failed (run #822) on import ordering and rustfmt line-wrapping. No functional changes; pure rustfmt output. #PMS-230
style: apply cargo fmt across modules and tests
Some checks failed
E2E (staging) / Playwright against staging (pull_request) Failing after 27s
Details
Check / fmt + clippy + compile + tests (pull_request) Successful in 2m16s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
bcb02006bc 
Reformat src/ and tests/ to satisfy `cargo fmt --check`, which the check.yml CI job ran before clippy/compile and which failed (run #822) on import ordering and rustfmt line-wrapping. No functional changes; pure rustfmt output.

#PMS-230
David commented 2026-06-13 12:43:24 +02:00
Author
Owner
Copy link

Closing as redundant and stale, same as #170. This PR's only commit was a cargo fmt fixup (PMS-230).

The formatting intent is already in main: PR #173 (chore: cargo fmt --all after the PMS-139 TenantId sweep, c441b1c) and PR #183 (chore(fmt): apply cargo fmt --all after PMS-244..PMS-249 sweep) reformatted the whole workspace.

The specific lines this PR reflows are obsolete. It wraps TenantId::from_trusted(tenant_id) at the tickets notify/dispatch call sites; the tickets hub was fully migrated to TenantId in PR #171 (sweep batch 8), so main now passes the already-typed tenant_id directly. That divergence is the source of the merge conflict (src/modules/tickets/automation.rs, src/modules/tickets/service.rs); resolving toward main loses nothing this PR intended, since it intended only formatting.

It is an AGit PR with no server branch (head only at refs/pull/172/head), so "Update Branch" was never available. Nothing left to merge.

Closing as redundant and stale, same as #170. This PR's only commit was a `cargo fmt` fixup (PMS-230). The formatting intent is already in `main`: PR #173 (`chore: cargo fmt --all after the PMS-139 TenantId sweep`, `c441b1c`) and PR #183 (`chore(fmt): apply cargo fmt --all after PMS-244..PMS-249 sweep`) reformatted the whole workspace. The specific lines this PR reflows are obsolete. It wraps `TenantId::from_trusted(tenant_id)` at the tickets notify/dispatch call sites; the tickets hub was fully migrated to `TenantId` in PR #171 (sweep batch 8), so `main` now passes the already-typed `tenant_id` directly. That divergence is the source of the merge conflict (`src/modules/tickets/automation.rs`, `src/modules/tickets/service.rs`); resolving toward `main` loses nothing this PR intended, since it intended only formatting. It is an AGit PR with no server branch (head only at `refs/pull/172/head`), so "Update Branch" was never available. Nothing left to merge.
David closed this pull request 2026-06-13 12:43:24 +02:00
Some checks are pending
E2E (staging) / Playwright against staging (pull_request) Failing after 27s
Details
Check / fmt + clippy + compile + tests (pull_request) Successful in 2m16s
Required
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
E2E / * (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-server!172
No description provided.