psa-systems/mokosh-apps
8
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(crm): the CompanyType variant is 'client', not 'customer' #56

Merged
YousifShkara merged 1 commit from feat/crm-ops into main 2026-06-04 08:52:37 +02:00
Conversation 0 Commits 1 Files changed 1 +6 -6
YousifShkara commented 2026-06-04 08:52:34 +02:00
Owner
Copy link

mokosh-server's CompanyType enum lists Client / Prospect / Vendor /
Partner. The client side had the wrong tag in three places:

  • humanize_company_type returned 'Customer' for tag 'customer'.
  • CompanyForm defaulted new companies to company_type='customer'.
  • The Companies list dropdown offered ('customer', 'Customer').

Server rejected every create with HTTP 422:
'Failed to deserialize the JSON body into the target type:
company_type: unknown variant customer, expected one of
client, prospect, vendor, partner'

Switch every site to 'client' / 'Client'. The badge-color match
arm flips from 'Customer' -> Green to 'Client' -> Green to match
the new humanized label.

Drive-by: also corrected the doc comment that listed the wrong
set of valid tags.

mokosh-server's CompanyType enum lists Client / Prospect / Vendor / Partner. The client side had the wrong tag in three places: - humanize_company_type returned 'Customer' for tag 'customer'. - CompanyForm defaulted new companies to company_type='customer'. - The Companies list dropdown offered ('customer', 'Customer'). Server rejected every create with HTTP 422: 'Failed to deserialize the JSON body into the target type: company_type: unknown variant customer, expected one of client, prospect, vendor, partner' Switch every site to 'client' / 'Client'. The badge-color match arm flips from 'Customer' -> Green to 'Client' -> Green to match the new humanized label. Drive-by: also corrected the doc comment that listed the wrong set of valid tags.
fix(crm): the CompanyType variant is 'client', not 'customer'
All checks were successful
Create release / Create release from merged PR (pull_request) Has been skipped
Details
Check / clippy + fmt + tests (pull_request) Successful in 33s
Details
9af4835da2 
mokosh-server's CompanyType enum lists Client / Prospect / Vendor /
Partner. The client side had the wrong tag in three places:

- humanize_company_type returned 'Customer' for tag 'customer'.
- CompanyForm defaulted new companies to company_type='customer'.
- The Companies list dropdown offered ('customer', 'Customer').

Server rejected every create with HTTP 422:
  'Failed to deserialize the JSON body into the target type:
   company_type: unknown variant customer, expected one of
   client, prospect, vendor, partner'

Switch every site to 'client' / 'Client'. The badge-color match
arm flips from 'Customer' -> Green to 'Client' -> Green to match
the new humanized label.

Drive-by: also corrected the doc comment that listed the wrong
set of valid tags.
YousifShkara deleted branch feat/crm-ops 2026-06-04 08:52:37 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
psa-systems/mokosh-apps!56
No description provided.