fix(calendar): keep the 12 AM row clear of the sticky header (MAPPS-387) #449

Merged
longjacksonle merged 1 commit from fix/MAPPS-387-midnight-row-clipped into main 2026-07-30 16:49:02 +02:00

MAPPS-387 follow-up: 12 AM row clipped by the sticky header

Reported on staging (ref-off.png): the top row (12 AM) is cut off and cannot be scrolled into view.

Cause

The hour-gutter labels carry -mt-2 so each label sits on its gridline. For the first row that pulls the 12 AM label up under the week grid's sticky day-of-week header (and off the top edge of the day view's scroll box). Since midnight is already at scroll-top, there was nothing above it to scroll to, so the label stayed hidden.

Fix

Add pt-2 (the same 8px) to the grid body of both the week and day views. This offsets the first label's negative margin so 12 AM clears the header and renders fully, while every other label stays aligned to its line. No behavior change to scrolling, geometry, or the dispatch timeline.

Verified: cargo fmt --all --check, cargo clippy --all-targets -- -D warnings, and cargo check --target wasm32-unknown-unknown all pass on 1.94.1.

## MAPPS-387 follow-up: 12 AM row clipped by the sticky header Reported on staging (ref-off.png): the top row (12 AM) is cut off and cannot be scrolled into view. ### Cause The hour-gutter labels carry `-mt-2` so each label sits on its gridline. For the first row that pulls the `12 AM` label up under the week grid's sticky day-of-week header (and off the top edge of the day view's scroll box). Since midnight is already at scroll-top, there was nothing above it to scroll to, so the label stayed hidden. ### Fix Add `pt-2` (the same 8px) to the grid body of both the week and day views. This offsets the first label's negative margin so 12 AM clears the header and renders fully, while every other label stays aligned to its line. No behavior change to scrolling, geometry, or the dispatch timeline. Verified: `cargo fmt --all --check`, `cargo clippy --all-targets -- -D warnings`, and `cargo check --target wasm32-unknown-unknown` all pass on 1.94.1.
fix(calendar): keep the 12 AM row clear of the sticky header (MAPPS-387)
All checks were successful
Check / fmt + clippy + tests (pull_request) Successful in 1m40s
Create release / Create release from merged PR (pull_request) Has been skipped
08088c2dc6
The hour-gutter labels use `-mt-2` to sit on their gridline, which for the first row (12 AM) pulls the label up under the day/week grid's sticky header (week) or off the top edge of the scroll box (day). Because midnight is already at scroll-top, it could not be scrolled into view. Pad the grid body top by the same 8px (`pt-2`) so the 12 AM label clears the header and renders fully, with every other label still aligned to its line.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QvB249F2SV9SBe3cBKRjcS
longjacksonle deleted branch fix/MAPPS-387-midnight-row-clipped 2026-07-30 16:49:02 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!449
No description provided.