fix(ui): let the user-menu icon inherit hover color (MAPPS-384 follow-up) #447

Merged

longjacksonle merged 1 commit from fix/MAPPS-384-profile-icon-hover-color into main

2026-07-28 19:44:16 +02:00

longjacksonle commented

2026-07-28 19:42:37 +02:00

Owner

Follow-up to #446 (MAPPS-384).

Problem

After #446 the user-profile icon still did not visibly light up on hover like the other top-bar icons. The trigger button got text-subtle hover:text-content hover:bg-surface-2, but the UserCircleIcon inside it still carried a hardcoded class: "text-subtle". Since the icon strokes with currentColor, that class pinned the icon color to text-subtle and overrode the button's hover:text-content, so the icon never brightened. The hover background changed, but the icon-color cue (the obvious one, and the one the sibling icons use) was suppressed.

Fix

Drop the color class from the icon so it inherits currentColor from the button, exactly like the sibling SwatchIcon {} (theme picker) and the notification bell. Applied to both UserMenu and the client-portal twin PortalUserMenu.

Verification

cargo fmt --all --check: clean.
Rebuilt via dx hot-reload against the local dev stack and confirmed the icon now brightens on hover, matching the theme-picker and bell icons.

Follow-up to #446 (MAPPS-384). ## Problem After #446 the user-profile icon still did not visibly light up on hover like the other top-bar icons. The trigger button got `text-subtle hover:text-content hover:bg-surface-2`, but the `UserCircleIcon` inside it still carried a hardcoded `class: "text-subtle"`. Since the icon strokes with `currentColor`, that class pinned the icon color to `text-subtle` and overrode the button's `hover:text-content`, so the icon never brightened. The hover background changed, but the icon-color cue (the obvious one, and the one the sibling icons use) was suppressed. ## Fix Drop the color class from the icon so it inherits `currentColor` from the button, exactly like the sibling `SwatchIcon {}` (theme picker) and the notification bell. Applied to both `UserMenu` and the client-portal twin `PortalUserMenu`. ## Verification - `cargo fmt --all --check`: clean. - Rebuilt via dx hot-reload against the local dev stack and confirmed the icon now brightens on hover, matching the theme-picker and bell icons.

longjacksonle added 1 commit

2026-07-28 19:42:37 +02:00

fix(ui): let the user-menu icon inherit hover color (MAPPS-384 follow-up)

Check / fmt + clippy + tests (pull_request) Successful in 1m36s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

a46db438a6

The MAPPS-384 fix gave the trigger button `text-subtle hover:text-content`, but the `UserCircleIcon` still carried a hardcoded `class: "text-subtle"`. Because the icon strokes with `currentColor`, that pinned the icon's color to `text-subtle` and overrode the button's `hover:text-content`, so the icon never brightened on hover the way the sibling top-bar icons do (e.g. `SwatchIcon {}`, which carries no color class and inherits from its button). The background changed on hover but the icon-color cue - the obvious one - was dead.

Drop the color class so the icon inherits `currentColor` from the button, matching the siblings. Applied to both `UserMenu` and the portal twin `PortalUserMenu`. Verified via dx hot-reload against the local dev build.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CEnKozf9UzwgoT1RUELYpb

longjacksonle scheduled this pull request to auto merge when all checks succeed

2026-07-28 19:43:57 +02:00