fix(pickers): set off '+ Create' row in its own band (MAPPS-320) #367
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/MAPPS-320-create-row-visual-separation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The CompanyPicker and ContactPicker dropdowns placed the inline '+ Create' row flush against the existing-match rows with identical row height and only a hairline border, so a hurried click meant for the highlighted match above could land on Create and spawn a duplicate company/contact (QA hit this twice across runs).
Render the Create affordance in a visually separate band: a 4px top gap (mt-1) above the existing top border, a muted bg-surface-2/50 background so the row reads as a different action, and a leading PlusIcon in place of the inline '+' glyph. The distinct hover (hover:bg-accent-50) is retained. The row stays in the same DOM position inside the dropdown, so Up/Down/Enter keyboard navigation still reaches it from the last match. The empty-state ('No matches' / 'No companies yet') branch gets the same treatment with no rendering regression.
#MAPPS-320
The CompanyPicker and ContactPicker dropdowns placed the inline '+ Create' row flush against the existing-match rows with identical row height and only a hairline border, so a hurried click meant for the highlighted match above could land on Create and spawn a duplicate company/contact (QA hit this twice across runs). Render the Create affordance in a visually separate band: a 4px top gap (mt-1) above the existing top border, a muted bg-surface-2/50 background so the row reads as a different action, and a leading PlusIcon in place of the inline '+' glyph. The distinct hover (hover:bg-accent-50) is retained. The row stays in the same DOM position inside the dropdown, so Up/Down/Enter keyboard navigation still reaches it from the last match. The empty-state ('No matches' / 'No companies yet') branch gets the same treatment with no rendering regression. #MAPPS-320