psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

feat(pickers): visually separate the inline '+ Create' row from match rows (MAPPS-320) #366

Open
YousifShkara wants to merge 1 commit from feat/MAPPS-320-picker-create-row-separation into main
pull from: feat/MAPPS-320-picker-create-row-separation
merge into: psa-systems:main
Conversation 1 Commits 1 Files changed 2 +66 -41
YousifShkara commented 2026-06-26 06:44:47 +02:00
Owner
Copy link

QA flagged the Company picker twice for a misclick risk: the '+ Create' row sat flush with the existing-match rows at the same row height and same hover treatment, so a user typing "Acme" and meaning to click "Acme Corp" could land on '+ Create "Acme"' and accidentally create a duplicate. Treat Create as a distinct action: top margin gap + border-t + muted band (bg-surface-2/60) + leading PlusIcon + taller padding, in both the empty-list and populated-list branches, in both CompanyPicker and ContactPicker. Keyboard chain (Down/Enter still reaches the Create button) and the inline-create modal flow are unchanged.

#MAPPS-320

QA flagged the Company picker twice for a misclick risk: the '+ Create' row sat flush with the existing-match rows at the same row height and same hover treatment, so a user typing "Acme" and meaning to click "Acme Corp" could land on '+ Create "Acme"' and accidentally create a duplicate. Treat Create as a distinct action: top margin gap + border-t + muted band (bg-surface-2/60) + leading PlusIcon + taller padding, in both the empty-list and populated-list branches, in both CompanyPicker and ContactPicker. Keyboard chain (Down/Enter still reaches the Create button) and the inline-create modal flow are unchanged. #MAPPS-320
feat(pickers): visually separate the inline '+ Create' row from match rows (MAPPS-320)
All checks were successful
Check / fmt + clippy + tests (pull_request) Successful in 1m36s
Details
f2d79d7800 
QA flagged the Company picker twice for a misclick risk: the '+ Create' row sat flush with the existing-match rows at the same row height and same hover treatment, so a user typing "Acme" and meaning to click "Acme Corp" could land on '+ Create "Acme"' and accidentally create a duplicate. Treat Create as a distinct action: top margin gap + border-t + muted band (bg-surface-2/60) + leading PlusIcon + taller padding, in both the empty-list and populated-list branches, in both CompanyPicker and ContactPicker. Keyboard chain (Down/Enter still reaches the Create button) and the inline-create modal flow are unchanged.

#MAPPS-320
vas2000-work force-pushed feat/MAPPS-320-picker-create-row-separation from f2d79d7800
All checks were successful
Check / fmt + clippy + tests (pull_request) Successful in 1m36s
Details
to 4f2b7a500f
All checks were successful
Check / fmt + clippy + tests (pull_request) Successful in 2m5s
Details
2026-07-01 07:06:05 +02:00 Compare
vas2000-work commented 2026-07-01 07:17:26 +02:00
Owner
Copy link

⚠️ History rewrite notice (PSA-48). This repo's git history was rewritten (contributor names stripped from commit messages; audit / how-it-was-built docs distilled into docs/dev-docs/CHANGELOG.md). This branch was force-updated to the sanitized history, so its commits are name-free.

This PR is ~79 commits behind main and currently conflicts, so I did not merge it. To update it:

  1. Re-sync your local checkout first (do NOT push your pre-rewrite local copy, it would reverse the sanitization):
    git fetch origin && git switch feat/MAPPS-320-picker-create-row-separation && git reset --hard origin/feat/MAPPS-320-picker-create-row-separation (or re-clone).
  2. Rebase onto the new origin/main to resolve the conflict, then push.
⚠️ **History rewrite notice (PSA-48).** This repo's git history was rewritten (contributor names stripped from commit messages; audit / how-it-was-built docs distilled into `docs/dev-docs/CHANGELOG.md`). This branch was force-updated to the sanitized history, so its commits are name-free. This PR is ~79 commits behind `main` and currently conflicts, so I did not merge it. To update it: 1. **Re-sync your local checkout first** (do NOT push your pre-rewrite local copy, it would reverse the sanitization): `git fetch origin && git switch feat/MAPPS-320-picker-create-row-separation && git reset --hard origin/feat/MAPPS-320-picker-create-row-separation` (or re-clone). 2. Rebase onto the new `origin/main` to resolve the conflict, then push.
All checks were successful
Check / fmt + clippy + tests (pull_request) Successful in 2m5s
Required
Details
This pull request has changes conflicting with the target branch.
  • src/components/company_picker.rs
  • src/components/contact_picker.rs
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/MAPPS-320-picker-create-row-separation:feat/MAPPS-320-picker-create-row-separation
git switch feat/MAPPS-320-picker-create-row-separation
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!366
No description provided.