psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

feat(phone): render stored phone numbers with separators (MAPPS-283) #303

Merged
YousifShkara merged 1 commit from feat/MAPPS-283-phone-format into main 2026-06-21 09:56:36 +02:00
Conversation 0 Commits 1 Files changed 1 +41 -5
YousifShkara commented 2026-06-21 09:28:17 +02:00
Owner
Copy link

The server stores phone numbers as the trimmed-formatting output of validate_phone_field (digits with an optional leading +). The QA report flagged that '(555) 123-4567' was being displayed back as '5551234567' on every read surface. Add a format_phone helper that re-applies NANP separators - 10 digits render as (555) 123-4567, 11 digits starting with 1 as +1 (555) 123-4567, and anything else passes through unchanged so non-NANP E.164 values keep their canonical form. Route every Phone / Mobile render on the contacts list, the company detail Phone line, the company-detail contacts preview, and the contact detail Phone / Mobile lines through it. Live input masking is heavier and would need editing-cursor coordination; tracked as a follow-up under MAPPS-283 - this captures the read-side win.

#MAPPS-283

The server stores phone numbers as the trimmed-formatting output of `validate_phone_field` (digits with an optional leading `+`). The QA report flagged that '(555) 123-4567' was being displayed back as '5551234567' on every read surface. Add a `format_phone` helper that re-applies NANP separators - 10 digits render as `(555) 123-4567`, 11 digits starting with `1` as `+1 (555) 123-4567`, and anything else passes through unchanged so non-NANP E.164 values keep their canonical form. Route every Phone / Mobile render on the contacts list, the company detail Phone line, the company-detail contacts preview, and the contact detail Phone / Mobile lines through it. Live input masking is heavier and would need editing-cursor coordination; tracked as a follow-up under MAPPS-283 - this captures the read-side win. #MAPPS-283
feat(phone): render stored phone numbers with separators (MAPPS-283)
All checks were successful
Check / clippy + fmt + tests (pull_request) Successful in 1m18s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
f80ea2459a 
The server stores phone numbers as the trimmed-formatting output of `validate_phone_field` (digits with an optional leading `+`). The QA report flagged that '(555) 123-4567' was being displayed back as '5551234567' on every read surface. Add a `format_phone` helper that re-applies NANP separators - 10 digits render as `(555) 123-4567`, 11 digits starting with `1` as `+1 (555) 123-4567`, and anything else passes through unchanged so non-NANP E.164 values keep their canonical form. Route every Phone / Mobile render on the contacts list, the company detail Phone line, the company-detail contacts preview, and the contact detail Phone / Mobile lines through it. Live input masking is heavier and would need editing-cursor coordination; tracked as a follow-up under MAPPS-283 - this captures the read-side win.

#MAPPS-283
YousifShkara deleted branch feat/MAPPS-283-phone-format 2026-06-21 09:56:37 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!303
No description provided.