fix(billing): validate New Invoice fields client-side #217

Merged

nrupard merged 2 commits from fix/MAPPS-214-invoice-form-validation into main

2026-06-16 16:26:35 +02:00

David commented

2026-06-16 15:39:47 +02:00

Owner

The New Invoice form let several bad line/header values through to an opaque 422. Add step="0.01" and min="0" to Unit Price so it accepts cents and rejects negatives, step="0.01"/min="0" to Quantity, and a submit-time check that flags a negative Quantity/Unit Price at the field instead of only in the generic banner. Add a Due Date >= Invoice Date check (ISO date lexicographic compare) that surfaces a field message before submit. Add client maxlength to Description (1000), PO Number (100), and Notes (2000) matching the server validator caps, and add the missing po_number/notes length validators on the invoice create/from-time-entries/update requests so client and server agree. Add maxlength props to the shared Input and Textarea components.

#MAPPS-214

The New Invoice form let several bad line/header values through to an opaque 422. Add `step="0.01"` and `min="0"` to Unit Price so it accepts cents and rejects negatives, `step="0.01"`/`min="0"` to Quantity, and a submit-time check that flags a negative Quantity/Unit Price at the field instead of only in the generic banner. Add a Due Date >= Invoice Date check (ISO date lexicographic compare) that surfaces a field message before submit. Add client `maxlength` to Description (1000), PO Number (100), and Notes (2000) matching the server validator caps, and add the missing `po_number`/`notes` length validators on the invoice create/from-time-entries/update requests so client and server agree. Add `maxlength` props to the shared Input and Textarea components. #MAPPS-214

David added 1 commit

2026-06-16 15:39:47 +02:00

fix(billing): validate New Invoice fields client-side

Check / clippy + fmt + tests (pull_request) Successful in 57s

Details

347369ef2a

The New Invoice form let several bad line/header values through to an opaque 422. Add `step="0.01"` and `min="0"` to Unit Price so it accepts cents and rejects negatives, `step="0.01"`/`min="0"` to Quantity, and a submit-time check that flags a negative Quantity/Unit Price at the field instead of only in the generic banner. Add a Due Date >= Invoice Date check (ISO date lexicographic compare) that surfaces a field message before submit. Add client `maxlength` to Description (1000), PO Number (100), and Notes (2000) matching the server validator caps, and add the missing `po_number`/`notes` length validators on the invoice create/from-time-entries/update requests so client and server agree. Add `maxlength` props to the shared Input and Textarea components.

#MAPPS-214

nrupard added 1 commit

2026-06-16 16:24:25 +02:00