psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

fix(tickets): AssetPicker inline-edit chip fits inside DetailItem row, no duplicate label (PMS-344 follow-up) #196

Merged
YousifShkara merged 1 commit from fix/pms-344-asset-picker-detailitem-layout into main 2026-06-16 11:06:13 +02:00
Conversation 0 Commits 1 Files changed 2 +49 -12
YousifShkara commented 2026-06-16 11:06:05 +02:00
Owner
Copy link

Two layout bugs in the ticket-detail Asset row. The AssetPicker's chip view always rendered its own "Asset" label, but the DetailItem wrapper already renders one on the left side of the row, so the value cell got a duplicate "Asset" label and the chip box dropped below it onto the next row (visibly overlapping Company). Conditionally suppress the picker's label when the parent passes an empty string, and mount it from the ticket detail editor with label: "", mirroring how the Status/Priority/Assigned-To Select editors already do it.

The chip box itself had no width constraint, so even after the label fix it would have sized to its content and overflowed the DetailItem value column. Added w-full min-w-0 on the chip wrapper, flex-1 min-w-0 on the value text column, and ml-2 on the button column so the long asset name and uuid truncate cleanly inside the dd cell. DetailItem's dd is now flex-1 min-w-0 so the value cell grows to fill the row width after the label; the right-anchored Select dropdowns are visually unchanged because their content stays small. Switched the row alignment to items-start so the multi-line chip aligns to the top of the label rather than the (now meaningless) baseline.

#PMS-344

Two layout bugs in the ticket-detail Asset row. The AssetPicker's chip view always rendered its own "Asset" label, but the DetailItem wrapper already renders one on the left side of the row, so the value cell got a duplicate "Asset" label and the chip box dropped below it onto the next row (visibly overlapping Company). Conditionally suppress the picker's label when the parent passes an empty string, and mount it from the ticket detail editor with `label: ""`, mirroring how the Status/Priority/Assigned-To Select editors already do it. The chip box itself had no width constraint, so even after the label fix it would have sized to its content and overflowed the DetailItem value column. Added `w-full min-w-0` on the chip wrapper, `flex-1 min-w-0` on the value text column, and `ml-2` on the button column so the long asset name and uuid truncate cleanly inside the dd cell. DetailItem's dd is now `flex-1 min-w-0` so the value cell grows to fill the row width after the label; the right-anchored Select dropdowns are visually unchanged because their content stays small. Switched the row alignment to `items-start` so the multi-line chip aligns to the top of the label rather than the (now meaningless) baseline. #PMS-344
fix(tickets): AssetPicker inline-edit chip fits inside DetailItem row, no duplicate label (PMS-344 follow-up)
All checks were successful
Create release / Create release from merged PR (pull_request) Has been skipped
Details
Check / clippy + fmt + tests (pull_request) Successful in 1m4s
Details
f10aefb30d 
Two layout bugs in the ticket-detail Asset row. The AssetPicker's chip view always rendered its own "Asset" label, but the DetailItem wrapper already renders one on the left side of the row, so the value cell got a duplicate "Asset" label and the chip box dropped below it onto the next row (visibly overlapping Company). Conditionally suppress the picker's label when the parent passes an empty string, and mount it from the ticket detail editor with `label: ""`, mirroring how the Status/Priority/Assigned-To Select editors already do it.

The chip box itself had no width constraint, so even after the label fix it would have sized to its content and overflowed the DetailItem value column. Added `w-full min-w-0` on the chip wrapper, `flex-1 min-w-0` on the value text column, and `ml-2` on the button column so the long asset name and uuid truncate cleanly inside the dd cell. DetailItem's dd is now `flex-1 min-w-0` so the value cell grows to fill the row width after the label; the right-anchored Select dropdowns are visually unchanged because their content stays small. Switched the row alignment to `items-start` so the multi-line chip aligns to the top of the label rather than the (now meaningless) baseline.

#PMS-344
YousifShkara deleted branch fix/pms-344-asset-picker-detailitem-layout 2026-06-16 11:06:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!196
No description provided.