psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

fix(tickets): asset inline-edit Change opens search picker without server roundtrip (PMS-344 follow-up) #194

Merged
YousifShkara merged 1 commit from fix/pms-344-asset-inline-change-opens-search into main 2026-06-16 10:13:07 +02:00
Conversation 0 Commits 1 Files changed 1 +68 -28
YousifShkara commented 2026-06-16 10:13:04 +02:00
Owner
Copy link

The ticket detail sidebar's Asset row showed the chip-with-Change pattern from the AssetPicker, where Change fired the parent's onclear. On the local-state pickers (New Ticket / New Contact CompanyPicker) that pattern works because the chip view re-renders into the search input as soon as the parent signal flips to empty. On the server-state inline editor introduced by PMS-344, onclear PUTs asset_id=null and the picker only swaps to search mode after the ticket-resource refetch completes, which to the user reads as "Change does nothing visible" - the verification round found zero inputs/comboboxes/popovers in the DOM after clicking Change, only the silent Updated change-history entry from the PUT.

Added an internal editing signal to the AssetPicker so Change toggles the search input locally without firing onclear or hitting the server. The async PUT now happens only when the user actually picks a replacement asset (or hits the separate Unassign button if they want to clear the association without picking a new one). The Unassign affordance is new on the chip view to preserve the previous clear-the-link capability that onclear used to provide directly via Change.

#PMS-344

The ticket detail sidebar's Asset row showed the chip-with-Change pattern from the AssetPicker, where Change fired the parent's onclear. On the local-state pickers (New Ticket / New Contact CompanyPicker) that pattern works because the chip view re-renders into the search input as soon as the parent signal flips to empty. On the server-state inline editor introduced by PMS-344, onclear PUTs asset_id=null and the picker only swaps to search mode after the ticket-resource refetch completes, which to the user reads as "Change does nothing visible" - the verification round found zero inputs/comboboxes/popovers in the DOM after clicking Change, only the silent Updated change-history entry from the PUT. Added an internal `editing` signal to the AssetPicker so Change toggles the search input locally without firing onclear or hitting the server. The async PUT now happens only when the user actually picks a replacement asset (or hits the separate Unassign button if they want to clear the association without picking a new one). The Unassign affordance is new on the chip view to preserve the previous clear-the-link capability that onclear used to provide directly via Change. #PMS-344
fix(tickets): asset inline-edit Change opens search picker without server roundtrip (PMS-344 follow-up)
All checks were successful
Create release / Create release from merged PR (pull_request) Has been skipped
Details
Check / clippy + fmt + tests (pull_request) Successful in 1m12s
Details
98ff84c090 
The ticket detail sidebar's Asset row showed the chip-with-Change pattern from the AssetPicker, where Change fired the parent's onclear. On the local-state pickers (New Ticket / New Contact CompanyPicker) that pattern works because the chip view re-renders into the search input as soon as the parent signal flips to empty. On the server-state inline editor introduced by PMS-344, onclear PUTs asset_id=null and the picker only swaps to search mode after the ticket-resource refetch completes, which to the user reads as "Change does nothing visible" - the verification round found zero inputs/comboboxes/popovers in the DOM after clicking Change, only the silent Updated change-history entry from the PUT.

Added an internal `editing` signal to the AssetPicker so Change toggles the search input locally without firing onclear or hitting the server. The async PUT now happens only when the user actually picks a replacement asset (or hits the separate Unassign button if they want to clear the association without picking a new one). The Unassign affordance is new on the chip view to preserve the previous clear-the-link capability that onclear used to provide directly via Change.

#PMS-344
YousifShkara deleted branch fix/pms-344-asset-inline-change-opens-search 2026-06-16 10:13:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!194
No description provided.