style(time): rustfmt work_type use_signal closure #161

Merged

nrupard merged 1 commit from fix/mapps-184-rustfmt-time into main

2026-06-15 20:49:24 +02:00

David commented

2026-06-15 20:35:38 +02:00

Owner

cargo fmt --check failed on the TimeEntryEditModal work_type signal at src/pages/time.rs:1125. Apply cargo fmt so the closure body is broken across lines per the project rustfmt config, restoring a green check.yml.

#MAPPS-184

David added 3 commits

2026-06-15 20:35:39 +02:00

feat(time): editable time entries (click-to-edit modal)

Check / clippy + fmt + tests (pull_request) Failing after 6s

Details

7e1279b427

MAPPS-166. Time entries were read-only on the list (the server already supports PUT/DELETE /time-entries/{id}). Make list rows click-to-edit, opening a modal that edits the common fields - work type, hours, date, description, billable - plus delete.

The modal reuses the server's update endpoint. Because that PUT direct-sets ticket_id/project_id/task_id (no COALESCE) and never recomputes company_id, the edit form intentionally keeps the work item and task fixed and re-sends their ids so a partial-looking update does not null them; to move an entry to a different work item, delete it and log again. RemoteTimeEntry gains id/work_type_id/task_id (and PartialEq) so a row can be edited.

Not compiled locally (no Rust toolchain in this environment); mirrors the existing Log Time form and the task/rate-card edit modals, and is gated by CI (cargo clippy --all-targets -- -D warnings).

#MAPPS-166

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(time): stop the edit modal from wiping task_id; UX tweaks

Check / clippy + fmt + tests (pull_request) Failing after 6s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

e0abe326da

Code-review follow-up on the time-entry edit modal.

- Do not send task_id on update. The time-entry response carries no task_id, so the client cannot echo the current value; sending the always-None value (or omitting it against the current direct-set update) would NULL a project entry's task on every edit. Drop task_id from RemoteTimeEntry and the PUT body. The server preserves it via COALESCE in PMS-328; this PR depends on that fix to be safe (merge after PMS-328).
- Relax the edit Hours field to step="any" / min="0" so an existing off-grid duration (e.g. a 10-minute entry -> 0.1667h) no longer renders the input :invalid; the save handler still enforces 0 < hours <= 24.
- Stop the Work Item ticket link click from also opening the row's edit modal (wrap it in a span that stops propagation); it now just navigates.

#MAPPS-166

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

style(time): rustfmt work_type use_signal closure

Check / clippy + fmt + tests (pull_request) Successful in 1m11s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

4971e941ee

cargo fmt --check failed on the TimeEntryEditModal work_type signal at src/pages/time.rs:1125. Apply cargo fmt so the closure body is broken across lines per the project rustfmt config, restoring a green check.yml.

#MAPPS-184