fix(just): cover MOKOSH_OIDC_CLIENT_ID in down defensive with-env #147
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/mapps-159-down-missing-oidc-client-id"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Docker Compose fully interpolates the merged config before running any subcommand, including
down, and aborts on any unset${VAR:?}required variable. The merged compose.yml + compose.dev-sso.yml declares three required vars (HOST_IP, USER, MOKOSH_OIDC_CLIENT_ID), but thedownrecipe's defensivewith-envblock only supplied HOST_IP and USER. On a fresh clone or beforejust register-clientpopulates the SPA client id,just down/just restartaborted withrequired variable MOKOSH_OIDC_CLIENT_ID is missing a value, defeating the recipe's defensive intent.Add a harmless teardown placeholder for MOKOSH_OIDC_CLIENT_ID alongside HOST_IP and USER. Teardown only identifies and removes resources, so the placeholder value is irrelevant to which containers/volumes get removed.
restartinherits the fix via itsdowndependency. Audited the full:?set in both compose files: USER and MOKOSH_OIDC_CLIENT_ID are the only required vars not provided by the shell, and both are now covered.#MAPPS-159
Docker Compose fully interpolates the merged config before running any subcommand, including `down`, and aborts on any unset `${VAR:?}` required variable. The merged compose.yml + compose.dev-sso.yml declares three required vars (HOST_IP, USER, MOKOSH_OIDC_CLIENT_ID), but the `down` recipe's defensive `with-env` block only supplied HOST_IP and USER. On a fresh clone or before `just register-client` populates the SPA client id, `just down` / `just restart` aborted with `required variable MOKOSH_OIDC_CLIENT_ID is missing a value`, defeating the recipe's defensive intent. Add a harmless teardown placeholder for MOKOSH_OIDC_CLIENT_ID alongside HOST_IP and USER. Teardown only identifies and removes resources, so the placeholder value is irrelevant to which containers/volumes get removed. `restart` inherits the fix via its `down` dependency. Audited the full `:?` set in both compose files: USER and MOKOSH_OIDC_CLIENT_ID are the only required vars not provided by the shell, and both are now covered. #MAPPS-159Closing as superseded by #146, which already merged the identical fix for MAPPS-159 into main. The defensive
downrecipe in main already supplies the MOKOSH_OIDC_CLIENT_ID teardown placeholder in its with-env block, so this branch carries no functional change (only comment wording differs on rebase).Pull request closed