feat(contracts): manage line items from the contract detail page

David commented

2026-06-16 14:09:23 +02:00

Owner

Contract line items had full backend CRUD (POST /contracts/{id}/items, PUT/DELETE /contract-items/{id}) but the detail page's Line Items card was read-only: no Add, Edit, or Delete affordance. Combined with the edit form intentionally hiding its own item editor, there was no way to add, correct, or remove a contract's line items after creation, and the derived contract Value could not be adjusted.

Add an "Add Item" action to the Line Items card header and make each row clickable, both opening a shared ContractItemFormModal that mirrors the create form's fields (name, type, quantity, unit price). New items POST to /contracts/{id}/items; editing an existing row PUTs to /contract-items/{id}; the modal retains the unexposed fields of the original row (description, included hours, rollover settings, sort_order) so a full-replace PUT does not wipe them. Delete uses the in-app ConfirmDialog (MAPPS-189), not window.confirm. On save or delete both the items table and the contract resource refresh so per-row totals and the Summary Value reflect the change.

item_type options now come from a shared contract_item_type_options() helper used by both the create form and the detail modal so they stay in sync with the server's item_type CHECK set (MAPPS-190). The stale "edit flow manages items from the detail page" comment on ContractFormValues.items is corrected to describe the now-real detail-page management.

#MAPPS-196

Contract line items had full backend CRUD (POST /contracts/{id}/items, PUT/DELETE /contract-items/{id}) but the detail page's Line Items card was read-only: no Add, Edit, or Delete affordance. Combined with the edit form intentionally hiding its own item editor, there was no way to add, correct, or remove a contract's line items after creation, and the derived contract Value could not be adjusted. Add an "Add Item" action to the Line Items card header and make each row clickable, both opening a shared ContractItemFormModal that mirrors the create form's fields (name, type, quantity, unit price). New items POST to /contracts/{id}/items; editing an existing row PUTs to /contract-items/{id}; the modal retains the unexposed fields of the original row (description, included hours, rollover settings, sort_order) so a full-replace PUT does not wipe them. Delete uses the in-app ConfirmDialog (MAPPS-189), not window.confirm. On save or delete both the items table and the contract resource refresh so per-row totals and the Summary Value reflect the change. item_type options now come from a shared contract_item_type_options() helper used by both the create form and the detail modal so they stay in sync with the server's item_type CHECK set (MAPPS-190). The stale "edit flow manages items from the detail page" comment on ContractFormValues.items is corrected to describe the now-real detail-page management. #MAPPS-196

David added 1 commit

2026-06-16 14:09:24 +02:00

feat(contracts): manage line items from the contract detail page

Check / clippy + fmt + tests (pull_request) Successful in 1m1s

Details

7d55c7572b

Contract line items had full backend CRUD (POST /contracts/{id}/items, PUT/DELETE /contract-items/{id}) but the detail page's Line Items card was read-only: no Add, Edit, or Delete affordance. Combined with the edit form intentionally hiding its own item editor, there was no way to add, correct, or remove a contract's line items after creation, and the derived contract Value could not be adjusted.

Add an "Add Item" action to the Line Items card header and make each row clickable, both opening a shared ContractItemFormModal that mirrors the create form's fields (name, type, quantity, unit price). New items POST to /contracts/{id}/items; editing an existing row PUTs to /contract-items/{id}; the modal retains the unexposed fields of the original row (description, included hours, rollover settings, sort_order) so a full-replace PUT does not wipe them. Delete uses the in-app ConfirmDialog (MAPPS-189), not window.confirm. On save or delete both the items table and the contract resource refresh so per-row totals and the Summary Value reflect the change.

item_type options now come from a shared contract_item_type_options() helper used by both the create form and the detail modal so they stay in sync with the server's item_type CHECK set (MAPPS-190). The stale "edit flow manages items from the detail page" comment on ContractFormValues.items is corrected to describe the now-real detail-page management.

#MAPPS-196

vas2000-work added 1 commit

2026-06-17 00:08:52 +02:00

Merge main into feat/mapps-196-contract-line-item-management

Check / clippy + fmt + tests (pull_request) Failing after 59s

Details

31b1188a0e

Resolve src/pages/contracts.rs: keep both signal decls - editing_item (MAPPS-196 line-item edit state) and confirming_delete (MAPPS-189 styled ConfirmDialog for the contract delete) that landed on main via #198.

#MAPPS-196

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>