fix(ui): replace native window.confirm() with styled ConfirmDialog for destructive actions

David commented

2026-06-16 12:28:49 +02:00

Owner

Every destructive action in the SPA prompted via the native browser window.confirm() (web_sys confirm_with_message). That dialog is unthemed OS chrome that ignores dark/high-contrast mode, is inconsistent with the app's existing styled Modal, and freezes the page event loop so browser automation (Claude-in-Chrome, Playwright) cannot drive any delete flow. This swaps all 14 remaining call sites onto the existing, themed, focus-trapped ConfirmDialog component (the same one PMS-369 already adopted for SLA targets).

SettingFormModal now owns the confirmation for the 10 settings lookup editors and the 2 contract rate-card / rate editors: the footer Delete button opens a ConfirmDialog and the caller's ondelete fires only on confirm. Its ondelete prop changed from EventHandler to EventHandler<()> to match. The settings delete_lookup helper no longer prompts (its native confirm_delete helper is removed) since confirmation now happens up front in the dialog.

The remaining detail-page, modal-form, table-row, and invoice-void sites (assets, contracts, contacts company/site/contact, projects, time entry, calendar appointment, billing void / payment / tax rate / gateway) each gained a confirming-delete signal: the Danger button opens the dialog and the actual request runs from an on_confirm_delete handler, mirroring the SLA reference pattern. No confirm_with_message / window.confirm calls remain in src (grep clean).

#MAPPS-189

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Every destructive action in the SPA prompted via the native browser window.confirm() (web_sys confirm_with_message). That dialog is unthemed OS chrome that ignores dark/high-contrast mode, is inconsistent with the app's existing styled Modal, and freezes the page event loop so browser automation (Claude-in-Chrome, Playwright) cannot drive any delete flow. This swaps all 14 remaining call sites onto the existing, themed, focus-trapped ConfirmDialog component (the same one PMS-369 already adopted for SLA targets). SettingFormModal now owns the confirmation for the 10 settings lookup editors and the 2 contract rate-card / rate editors: the footer Delete button opens a ConfirmDialog and the caller's ondelete fires only on confirm. Its ondelete prop changed from EventHandler<MouseEvent> to EventHandler<()> to match. The settings delete_lookup helper no longer prompts (its native confirm_delete helper is removed) since confirmation now happens up front in the dialog. The remaining detail-page, modal-form, table-row, and invoice-void sites (assets, contracts, contacts company/site/contact, projects, time entry, calendar appointment, billing void / payment / tax rate / gateway) each gained a confirming-delete signal: the Danger button opens the dialog and the actual request runs from an on_confirm_delete handler, mirroring the SLA reference pattern. No confirm_with_message / window.confirm calls remain in src (grep clean). #MAPPS-189 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

David added 1 commit

2026-06-16 12:28:49 +02:00

fix(ui): replace native window.confirm() with styled ConfirmDialog for destructive actions

Check / clippy + fmt + tests (pull_request) Successful in 1m0s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

dd3485f45b

Every destructive action in the SPA prompted via the native browser window.confirm() (web_sys confirm_with_message). That dialog is unthemed OS chrome that ignores dark/high-contrast mode, is inconsistent with the app's existing styled Modal, and freezes the page event loop so browser automation (Claude-in-Chrome, Playwright) cannot drive any delete flow. This swaps all 14 remaining call sites onto the existing, themed, focus-trapped ConfirmDialog component (the same one PMS-369 already adopted for SLA targets).

SettingFormModal now owns the confirmation for the 10 settings lookup editors and the 2 contract rate-card / rate editors: the footer Delete button opens a ConfirmDialog and the caller's ondelete fires only on confirm. Its ondelete prop changed from EventHandler<MouseEvent> to EventHandler<()> to match. The settings delete_lookup helper no longer prompts (its native confirm_delete helper is removed) since confirmation now happens up front in the dialog.

The remaining detail-page, modal-form, table-row, and invoice-void sites (assets, contracts, contacts company/site/contact, projects, time entry, calendar appointment, billing void / payment / tax rate / gateway) each gained a confirming-delete signal: the Danger button opens the dialog and the actual request runs from an on_confirm_delete handler, mirroring the SLA reference pattern. No confirm_with_message / window.confirm calls remain in src (grep clean).

#MAPPS-189

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>