feat: Phase 8 — Typing Indicators & Phase 9 — Private Rooms #7

Merged

longjacksonle merged 21 commits from long-branch into main

2026-04-13 14:59:27 +02:00

longjacksonle commented

2026-04-13 14:59:22 +02:00

Owner

Summary

Phase 8 — Typing Indicators

WebSocket hub tracks active typers per room; broadcasts UserTyping /
UserStoppedTyping events
New Typing client control message; WsHandle.send_typing() helper throttles to
once per second per room
Room view and DM view both show live typing banners ("X is typing…", "X and Y
are typing…", "Several people are typing…")
Typer is cleared from the list when their message arrives, avoiding stale
indicators

Phase 9 — Private / Invite-Only Rooms

DB migration adds invite_code TEXT column to rooms with a unique index
list_rooms now filters: non-admins see only public rooms plus private rooms
they're members of; admins see all
send_message and list_messages enforce room access — private rooms reject
non-members with Access denied
get_room_by_invite, regenerate_invite_code
New server functions: join_room_by_invite, leave_room, invite_user_to_room
(mod+), regenerate_invite_code (admin)
/invite/:code route — visiting the link auto-joins and redirects to the room
Admin Rooms panel shows type badges, invite link copy, regenerate button, and
direct invite-by-username field
Room creator is auto-added as a member on creation; RoomMemberAdded WS event
fires so their sidebar refreshes immediately
Sidebar reacts to RoomMemberAdded / RoomMemberRemoved events to refresh room
list without a page reload
7 integration tests: member visibility, access control, invite lookup,
idempotent add, code regeneration

Bug fixes (shipped in this branch)

RefCell already borrowed WASM panic — all oninput and onclick signal mutations
now run inside spawn(async move { ... }), deferring them past the event handler's
RefCell borrow
Form GET submissions — login, register, room composer, DM composer converted
from to
+ type="button" + onkeydown Enter handling;
credentials no longer appear in the URL
Room switching without reload — room_id prop is synced into a reactive Signal
each render so use_server_future re-runs when navigating between rooms
Hook ordering — use_navigator() and use_context_provider moved to unconditional
call sites in AuthLayout
DB persistence — named Docker volume lets_chat_data:/data added to
compose.dev.yml so SQLite databases survive container rebuilds

Test plan

Register a new account — fields stay populated, no URL leaking, redirects to
home on success
Log out and log back in — login form works consistently
Click between #general and #random — room content switches without a page reload
Send messages in a room and DM — Enter key and Send button both work; no GET
redirect
Create a private room in Admin → Rooms — room appears in creator's sidebar
immediately
Copy invite link and open in another browser session — user joins and room
appears in their sidebar
Invite a user by username from the admin panel — they see the room without using
an invite link
Confirm non-members get Access denied when accessing a private room directly
Verify typing indicator appears and clears correctly in both rooms and DMs
Run cargo test — all 45 tests pass

Summary Phase 8 — Typing Indicators - WebSocket hub tracks active typers per room; broadcasts UserTyping / UserStoppedTyping events - New Typing client control message; WsHandle.send_typing() helper throttles to once per second per room - Room view and DM view both show live typing banners ("X is typing…", "X and Y are typing…", "Several people are typing…") - Typer is cleared from the list when their message arrives, avoiding stale indicators Phase 9 — Private / Invite-Only Rooms - DB migration adds invite_code TEXT column to rooms with a unique index - list_rooms now filters: non-admins see only public rooms plus private rooms they're members of; admins see all - send_message and list_messages enforce room access — private rooms reject non-members with Access denied get_room_by_invite, regenerate_invite_code - New server functions: join_room_by_invite, leave_room, invite_user_to_room (mod+), regenerate_invite_code (admin) - /invite/:code route — visiting the link auto-joins and redirects to the room - Admin Rooms panel shows type badges, invite link copy, regenerate button, and direct invite-by-username field - Room creator is auto-added as a member on creation; RoomMemberAdded WS event fires so their sidebar refreshes immediately - Sidebar reacts to RoomMemberAdded / RoomMemberRemoved events to refresh room list without a page reload - 7 integration tests: member visibility, access control, invite lookup, idempotent add, code regeneration Bug fixes (shipped in this branch) - RefCell already borrowed WASM panic — all oninput and onclick signal mutations now run inside spawn(async move { ... }), deferring them past the event handler's RefCell borrow - Form GET submissions — login, register, room composer, DM composer converted from <form onsubmit> to <div> + type="button" + onkeydown Enter handling; credentials no longer appear in the URL - Room switching without reload — room_id prop is synced into a reactive Signal each render so use_server_future re-runs when navigating between rooms - Hook ordering — use_navigator() and use_context_provider moved to unconditional call sites in AuthLayout - DB persistence — named Docker volume lets_chat_data:/data added to compose.dev.yml so SQLite databases survive container rebuilds Test plan - Register a new account — fields stay populated, no URL leaking, redirects to home on success - Log out and log back in — login form works consistently - Click between #general and #random — room content switches without a page reload - Send messages in a room and DM — Enter key and Send button both work; no GET redirect - Create a private room in Admin → Rooms — room appears in creator's sidebar immediately - Copy invite link and open in another browser session — user joins and room appears in their sidebar - Invite a user by username from the admin panel — they see the room without using an invite link - Confirm non-members get Access denied when accessing a private room directly - Verify typing indicator appears and clears correctly in both rooms and DMs - Run cargo test — all 45 tests pass

longjacksonle added 21 commits

2026-04-13 14:59:22 +02:00

docs(readme): rewrite with features, tech stack, and docker quickstart 57bcf95b58

docs(plan): add phase 9 private rooms implementation plan 01c016d421

feat(ws): add RoomMemberAdded and RoomMemberRemoved chat events e3a4aacc7e

feat(models): add invite_code field to Room struct 8ef9eb4207

feat(server_fns): enforce private room access control on chat endpoints c6b5035fe0

feat(db): run migration 005 for private rooms on startup fc2be1914c

feat(migrations): add invite_code column and index for private rooms 14f7b9e0bf

feat(routes): add /invite/:code route for private room invites a649a2ccee

feat(routes): wire Invite component to InvitePage a501086093

feat(components): add InvitePage component for joining rooms via invite code f57eefb0d8

feat(db): add room membership queries and private room visibility ce8945b23c

Extend `list_rooms` to filter by membership for non-admin users, add
`is_room_member`, `add_room_member`, `remove_room_member`,
`get_room_by_invite`, and `regenerate_invite_code` helpers. Update
`create_room` to accept `room_type` and `invite_code`. Deduplicate row
mapping via a shared `map_room` helper.

feat(server_fns): add room type, invite user, and regenerate invite code endpoints 18f901f586

feat(components): add room type selector and invite controls to admin rooms UI bbe7f60484

feat(server_fns): register rooms module in mod.rs ae0951e84f

feat(tests): add private rooms test suite and migrate existing tests to new signatures b92ffb7dd8

feat(components): migrate user context to Signal<Option<User>> and replace form submit with explicit handlers da70a9e2cc

- Update all components to use Signal<Option<User>> instead of Signal<User>
- Replace form onsubmit handlers with spawn-based do_login/do_register closures that support Enter key submission
- Add rooms_version signal to sidebar for reactive refresh on room membership changes
- Rename use_invite_code to redeem_invite_code in test

feat(server_fns): add join/leave room server fns and fix invite_code migration 9dce49778e

- Add join_room_by_invite and leave_room server functions
- Fix invite_code uniqueness: move UNIQUE constraint to index instead of column definition
- Rename use_invite_code to redeem_invite_code for clarity
- Refactor AuthLayout to hoist hooks unconditionally and use Signal<Option<User>>

chore: mark phase 9 complete and update dev/test config efd86f3a73

- Check all phase 9 checklist items as done in plan and TODO
- Mount tests/ and lets_chat_data volume in compose.dev.yml
- Expand explicit test list in justfile test recipe
- Add cargo check, dx check, cargo test to allowed Claude tools

feat(components): fix room navigation reactivity and auto-add creator on room creation 22732932e4

Replace parsed_id with a reactive Signal in RoomViewPage so switching
rooms re-runs server futures and WS subscriptions. Also auto-join the
creator as a room member in create_room and broadcast RoomMemberAdded.

fix(components): wrap signal mutations in spawn for Dioxus 0.7 compatibility 27656854d4

fix(components): wrap oninput handlers in spawn for login, register, and dm_view b5143991ed