psa-systems/lets-chat
Watch
9
0
Fork
You've already forked lets-chat
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

chore(css): remove dead .lc-empty-wrap helper (LC-578) #544

Merged
longjacksonle merged 1 commit from chore/lc-578-remove-dead-lc-empty-wrap into main 2026-07-12 03:59:05 +02:00
Conversation 0 Commits 1 Files changed 1 +2 -5
longjacksonle commented 2026-07-12 03:54:11 +02:00
Owner
Copy link

Resolves LC-578 (follow-up on LC-555 / LC-UI-02).

The LC-555 reconcile comment flagged three shared helpers as dead CSS and asked to either adopt them on a real page or close: .lc-toolbar, .lc-action-row, .lc-empty-wrap.

LC-572 (admin header restructure) already put two of them on real admin pages: .lc-toolbar drives the analytics date-range filter strip, and .lc-action-row wraps the bridges/invites card footers. Those are now live and verified adopted.

.lc-empty-wrap is the only one still unused, and it duplicates the already-shipped .lc-empty (main.css) that every empty state renders through partials/empty_state.html (all admin tables plus the room About/Manage surfaces). Adopting a second near-identical centering wrapper would re-introduce exactly the duplication LC-555 set out to eliminate, so this PR deletes the rule and trims its mention from the LC-555 helper comment.

No template references .lc-empty-wrap, so there are no markup changes. just build-css regenerates cleanly; the gitignored tailwind-built.css no longer carries the rule.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GJbJChgMXj7m1Q8GdnTPyT

Resolves LC-578 (follow-up on LC-555 / LC-UI-02). The LC-555 reconcile comment flagged three shared helpers as dead CSS and asked to either adopt them on a real page or close: `.lc-toolbar`, `.lc-action-row`, `.lc-empty-wrap`. LC-572 (admin header restructure) already put two of them on real admin pages: `.lc-toolbar` drives the analytics date-range filter strip, and `.lc-action-row` wraps the bridges/invites card footers. Those are now live and verified adopted. `.lc-empty-wrap` is the only one still unused, and it duplicates the already-shipped `.lc-empty` (main.css) that every empty state renders through `partials/empty_state.html` (all admin tables plus the room About/Manage surfaces). Adopting a second near-identical centering wrapper would re-introduce exactly the duplication LC-555 set out to eliminate, so this PR deletes the rule and trims its mention from the LC-555 helper comment. No template references `.lc-empty-wrap`, so there are no markup changes. `just build-css` regenerates cleanly; the gitignored `tailwind-built.css` no longer carries the rule. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01GJbJChgMXj7m1Q8GdnTPyT
chore(css): remove dead .lc-empty-wrap helper (LC-578)
All checks were successful
check-secrets / Nosey parker (push) Successful in 6s
Details
check-secrets / Kingfisher (push) Successful in 10s
Details
check-secrets / TruffleHog (push) Successful in 10s
Details
check-secrets / Nosey parker (pull_request) Successful in 37s
Details
check-secrets / Kingfisher (pull_request) Successful in 1m20s
Details
check-secrets / TruffleHog (pull_request) Successful in 1m21s
Details
Check / clippy + fmt + tests (pull_request) Successful in 4m51s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
5d4706739e 
Reconcile of LC-555 flagged `.lc-toolbar`, `.lc-action-row`, `.lc-empty-wrap` as unadopted helpers. LC-572 since put `.lc-toolbar` (analytics filter strip) and `.lc-action-row` (bridges/invites footers) on real admin pages, so those two are live.

`.lc-empty-wrap` was the last dead one and it duplicates the shipped `.lc-empty` (main.css), which every empty state already uses through `partials/empty_state.html`. Keeping a second near-identical centering wrapper would re-introduce the duplication LC-555 set out to remove, so drop it. No template references `.lc-empty-wrap`; markup is untouched.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GJbJChgMXj7m1Q8GdnTPyT
longjacksonle scheduled this pull request to auto merge when all checks succeed 2026-07-12 03:56:56 +02:00
longjacksonle deleted branch chore/lc-578-remove-dead-lc-empty-wrap 2026-07-12 03:59:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/lets-chat!544
No description provided.