Rewrite Phase 3 plan with verified literal pixel-match gaps #538

Merged
vas2000-work merged 2 commits from docs/pixel-match-phase3-literal-gaps into main 2026-07-11 06:23:46 +02:00
Owner

Docs-only. Rewrites Phase 3 of the mockup pixel-match plan to reflect a verified, region-by-region gap assessment run on 2026-07-10 against the six comps and the static reference, and records the direction decision (LITERAL pixel-match).

Why: the original Phase 3 framed the remaining work as "fine spacing/radii/typography nudging." The assessment shows that is an undercount. Four regions (rail, right column, composer, and to a lesser degree header/sidebar) have structural/archetype mismatches that require markup restructuring, not token tweaks. The running app is also deliberately feature-richer than the comps, so a literal match requires hiding or relocating shipped affordances (enclave switcher, huddles, catch-me-up, polls, scheduling, semantic search, the 7-row nav section, per-message overflow menus). That is a product decision, so each feature-hide is called out as needing its own LC-553 sub-ticket rather than being folded silently into a CSS pass.

What changed in the doc:

  • Adds a "Phase 3 scope revision" block with the literal pixel-match decision and a severity scorecard (rail/right-column/composer = structural, header/sidebar = major, timeline = mixed, details = close).
  • Folds exact current-vs-target deltas (px, tokens, weights) into each Task 11-16 Step 1 so the implementer does not re-derive them.
  • Flags the token blocker where .lc-sidebar remaps --accent-surface to --sidebar-elevated, which prevents the comp's solid-accent active row from ever rendering.
  • Retitles Task 15 to cover the whole 360px right column (Thread plus Details) and notes the Phase 2 Details panel does not fully match (filled red button vs red-text link, missing chevron, hidden on public rooms).

No code, CSS, or i18n touched. Confirmed against the current templates on main; the shell widths, amethyst palette, and connection-status banner already match and are marked so.

#LC-569

Docs-only. Rewrites Phase 3 of the mockup pixel-match plan to reflect a verified, region-by-region gap assessment run on 2026-07-10 against the six comps and the static reference, and records the direction decision (LITERAL pixel-match). Why: the original Phase 3 framed the remaining work as "fine spacing/radii/typography nudging." The assessment shows that is an undercount. Four regions (rail, right column, composer, and to a lesser degree header/sidebar) have structural/archetype mismatches that require markup restructuring, not token tweaks. The running app is also deliberately feature-richer than the comps, so a literal match requires hiding or relocating shipped affordances (enclave switcher, huddles, catch-me-up, polls, scheduling, semantic search, the 7-row nav section, per-message overflow menus). That is a product decision, so each feature-hide is called out as needing its own LC-553 sub-ticket rather than being folded silently into a CSS pass. What changed in the doc: - Adds a "Phase 3 scope revision" block with the literal pixel-match decision and a severity scorecard (rail/right-column/composer = structural, header/sidebar = major, timeline = mixed, details = close). - Folds exact current-vs-target deltas (px, tokens, weights) into each Task 11-16 Step 1 so the implementer does not re-derive them. - Flags the token blocker where `.lc-sidebar` remaps `--accent-surface` to `--sidebar-elevated`, which prevents the comp's solid-accent active row from ever rendering. - Retitles Task 15 to cover the whole 360px right column (Thread plus Details) and notes the Phase 2 Details panel does not fully match (filled red button vs red-text link, missing chevron, hidden on public rooms). No code, CSS, or i18n touched. Confirmed against the current templates on main; the shell widths, amethyst palette, and connection-status banner already match and are marked so. #LC-569
docs(plan): rewrite Phase 3 with verified literal pixel-match gaps
All checks were successful
check-secrets / TruffleHog (push) Successful in 5s
check-secrets / Nosey parker (push) Successful in 5s
check-secrets / Kingfisher (push) Successful in 7s
check-secrets / Nosey parker (pull_request) Successful in 4s
check-secrets / Kingfisher (pull_request) Successful in 6s
check-secrets / TruffleHog (pull_request) Successful in 7s
Check / clippy + fmt + tests (pull_request) Successful in 3m14s
4da139eef5
Region-by-region gap assessment (2026-07-10) against the six comps and the static reference replaces the "fine nudging" framing of Phase 3. Records the LITERAL pixel-match decision: the running app is feature-richer than the comps, so the extra affordances (enclave switcher, huddles, catch-me-up, polls, scheduling, semantic search, 7-row nav, per-message overflow menus) must be hidden or relocated out of the chat surface, each behind its own LC-553 sub-ticket since hiding shipped functionality is a product decision beyond a CSS pass.

Adds a severity scorecard (rail/right-column/composer are structural, header/sidebar major, timeline mixed, details close) and folds exact current-vs-target deltas (px, tokens, weights) into each Task 11-16 Step 1 so the implementer does not re-derive them. Flags the blocker where .lc-sidebar remaps --accent-surface to --sidebar-elevated, which prevents the comp's solid-accent active row from ever rendering. Task 15 now covers the whole 360px right column (Thread plus Details), confirming the Phase 2 Details panel does not fully match.

#LC-569
Merge branch 'main' into docs/pixel-match-phase3-literal-gaps
All checks were successful
check-secrets / TruffleHog (pull_request) Successful in 5s
check-secrets / TruffleHog (push) Successful in 5s
check-secrets / Nosey parker (push) Successful in 5s
check-secrets / Nosey parker (pull_request) Successful in 6s
check-secrets / Kingfisher (pull_request) Successful in 8s
check-secrets / Kingfisher (push) Successful in 7s
Check / clippy + fmt + tests (pull_request) Successful in 3m34s
Create release / Create release from merged PR (pull_request) Has been skipped
43eef075c3
vas2000-work deleted branch docs/pixel-match-phase3-literal-gaps 2026-07-11 06:23:46 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/lets-chat!538
No description provided.