fix(room): tokenize the inline edit form (LC-558) #527
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/LC-558-timeline-polish"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
LC-UI-05: tokenize the inline edit form (last raw-color file in the timeline)
Phase 2. The concrete, verifiable slice of the timeline-polish ticket: the message edit form was the last file using a hardcoded Tailwind color.
What changed (
templates/room/edit_form.html)bg-yellow-50->bg-warning-surface. The raw amber never recolored, so in dark/hc themes the edit form was a bright light-amber box; the token gives the correct dim amber surface per theme.<textarea>(w-full border rounded px-2 py-1) -> the shared.inputcomponent, so it themes its border/background/text/placeholder in all four themes. All attributes (name, autofocus, rows, Escape/Ctrl+Enter keybindings) unchanged, and the form keepsid="msg-{id}"so the edit -> viewhx-swapround-trip is intact.Safety
routes_math_round_trip+routes_drafts(which render the edit form, including the autofocus assertion) pass 43/43.Deferred (with reason)
The subjective polish in LC-UI-05 (author/timestamp hierarchy, softening the hover action chip, day/unread-divider contrast) is intentionally not in this PR:
var(--accent)viacolor-mix(tokenized, recolors per theme), so that acceptance item is already satisfied.message.html(msg-{id}, reactions-{id}, seen-{id}, followup-{id}, reply-count-{id}, poll-{id}) and are safer as a separate focused pass.🤖 Generated with Claude Code
https://claude.ai/code/session_011jXpZXXwpB36MvTr6JrGXN
- Replaces the hardcoded `bg-yellow-50` on the message edit form with the tokenized `bg-warning-surface`. The raw amber never recolored, so in dark/hc themes the edit form rendered as a bright light-amber box; the token gives the dim amber surface per theme. This was the last hardcoded-color file the redesign audit flagged in the timeline. - Upgrades the raw edit `<textarea>` (`w-full border rounded px-2 py-1`) to the shared `.input` component so it picks up tokenized border/background/text + placeholder in every theme instead of a bare border. Attributes (name, autofocus, rows, the Escape/Ctrl+Enter keybindings) are unchanged, and the form keeps its `id="msg-{id}"` so the edit->view hx-swap round-trip is untouched. - Verified: `routes_math_round_trip` + `routes_drafts` (which render the edit form, incl. the autofocus test) pass 43/43. No new classes (both are already in the build), so no Tailwind rebuild. The subjective timeline polish in LC-UI-05 (author/timestamp hierarchy, softening the hover action chip, day/unread-divider contrast) is deferred: the mention highlight already uses `var(--accent)` (tokenized, recolors per theme) so that item is satisfied, and the rest needs visual iteration against the OOB-heavy message.html, best done as a separate focused pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011jXpZXXwpB36MvTr6JrGXN