feat(desktop): wire macOS WKWebView getUserMedia permission hook (LC-134) #453

Merged

vas2000-work merged 2 commits from feat/LC-134-macos-getusermedia-hooks into main 2026-06-28 02:21:00 +02:00

Conversation 0 Commits 2 Files changed 3 +77 -10

Claude-Run commented 2026-06-26 10:23:58 +02:00

Member

Copy link

Adds the macOS slice of the cross-platform getUserMedia permission work (sibling of the existing Linux WebKit2GTK and Windows WebView2 handlers).

The WebKit-layer consent is already auto-granted on macOS: wry's WryWebViewUIDelegate implements requestMediaCapturePermissionForOrigin and calls the decision handler with WKPermissionDecision::Grant, so installing our own WKUIDelegate would only clobber wry's (file-upload panels, new-window handling). The macOS arm of install_media_permission_handler is therefore an explicit, documented no-op rather than the previous silent catch-all.

The actual macOS-specific requirement is the OS-level (TCC) prompt. WKWebView reaches the camera/mic through AVFoundation in the host app process, which macOS silently denies (or terminates the app) unless the bundle declares usage strings. desktop/Info.plist adds NSCameraUsageDescription and NSMicrophoneUsageDescription (auto-merged by tauri-bundler), and desktop/lets-chat.entitlements adds com.apple.security.device.camera / audio-input for the default hardened runtime, wired via bundle.macOS.entitlements. Together these yield exactly one OS prompt on the first call, remembered across launches.

These artifacts only take effect once the macOS build/sign/notarize path lands under LC-126 (currently parked); on Linux/Windows builds they are ignored and the new macOS cfg arm is compiled out, so just check / just test-desktop stay green.

#LC-134

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Adds the macOS slice of the cross-platform getUserMedia permission work (sibling of the existing Linux WebKit2GTK and Windows WebView2 handlers). The WebKit-layer consent is already auto-granted on macOS: wry's WryWebViewUIDelegate implements requestMediaCapturePermissionForOrigin and calls the decision handler with WKPermissionDecision::Grant, so installing our own WKUIDelegate would only clobber wry's (file-upload panels, new-window handling). The macOS arm of install_media_permission_handler is therefore an explicit, documented no-op rather than the previous silent catch-all. The actual macOS-specific requirement is the OS-level (TCC) prompt. WKWebView reaches the camera/mic through AVFoundation in the host app process, which macOS silently denies (or terminates the app) unless the bundle declares usage strings. desktop/Info.plist adds NSCameraUsageDescription and NSMicrophoneUsageDescription (auto-merged by tauri-bundler), and desktop/lets-chat.entitlements adds com.apple.security.device.camera / audio-input for the default hardened runtime, wired via bundle.macOS.entitlements. Together these yield exactly one OS prompt on the first call, remembered across launches. These artifacts only take effect once the macOS build/sign/notarize path lands under LC-126 (currently parked); on Linux/Windows builds they are ignored and the new macOS cfg arm is compiled out, so just check / just test-desktop stay green. #LC-134 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Claude-Run added 1 commit 2026-06-26 10:23:58 +02:00

feat(desktop): wire macOS WKWebView getUserMedia permission hook (LC-134) ... 249e1a5259

Adds the macOS slice of the cross-platform getUserMedia permission work (sibling of the existing Linux WebKit2GTK and Windows WebView2 handlers).

The WebKit-layer consent is already auto-granted on macOS: wry's WryWebViewUIDelegate implements requestMediaCapturePermissionForOrigin and calls the decision handler with WKPermissionDecision::Grant, so installing our own WKUIDelegate would only clobber wry's (file-upload panels, new-window handling). The macOS arm of install_media_permission_handler is therefore an explicit, documented no-op rather than the previous silent catch-all.

The actual macOS-specific requirement is the OS-level (TCC) prompt. WKWebView reaches the camera/mic through AVFoundation in the host app process, which macOS silently denies (or terminates the app) unless the bundle declares usage strings. desktop/Info.plist adds NSCameraUsageDescription and NSMicrophoneUsageDescription (auto-merged by tauri-bundler), and desktop/lets-chat.entitlements adds com.apple.security.device.camera / audio-input for the default hardened runtime, wired via bundle.macOS.entitlements. Together these yield exactly one OS prompt on the first call, remembered across launches.

These artifacts only take effect once the macOS build/sign/notarize path lands under LC-126 (currently parked); on Linux/Windows builds they are ignored and the new macOS cfg arm is compiled out, so just check / just test-desktop stay green.

#LC-134

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

vas2000-work added 1 commit 2026-06-28 02:10:15 +02:00

Merge remote-tracking branch 'origin/main' into feat/LC-134-macos-getusermedia-hooks ... 4abdc52a1b

# Conflicts:
#	desktop/lets-chat.entitlements
#	desktop/src/main.rs

vas2000-work merged commit e214af2912 into main 2026-06-28 02:21:00 +02:00

vas2000-work referenced this pull request from a commit 2026-06-28 02:21:02 +02:00

Merge pull request 'feat(desktop): wire macOS WKWebView getUserMedia permission hook (LC-134)' (#453) from feat/LC-134-macos-getusermedia-hooks into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

psa-systems/lets-chat!453

No description provided.