fix(settings): confirm profile-picture upload and refresh the preview (LC-347) #365

Merged

longjacksonle merged 3 commits from fix/lc-347-avatar-upload-feedback into main 2026-06-19 04:21:43 +02:00

Conversation 0 Commits 3 Files changed 4 +195 -2

longjacksonle commented 2026-06-19 04:20:54 +02:00

Owner

Copy link

Fixes LC-347.

Problem

Uploading a profile picture at /settings gave no signal it worked: no success message, and the avatar preview looked unchanged, so it read as a failure even though the upload succeeded server-side.

Root causes (both confirmed in code)

1. No success feedback. routes::settings::post_profile redirected to /settings instead of /settings?saved=1, so the existing "Saved." flash (used by post_language / post_appearance) never fired.
2. Stale preview. The preview <img src="/avatars/{id}?v={asset_version}"> was keyed by asset_version, a build-time constant that never changes on upload, while routes::avatar::get_avatar serves Cache-Control: max-age=300. The browser kept showing the cached old image for up to five minutes.

Fix

• post_profile redirects to /settings?saved=1.
• The preview is cache-busted by the avatar file's mtime (new avatar_cache_key helper, surfaced as UserSettingsPage.avatar_version), so the new image loads immediately.

Tests

New server/tests/routes_settings_profile.rs:

• avatar_upload_redirects_to_saved_flash - POST multipart avatar returns 303 to /settings?saved=1 and persists avatar_ext.
• settings_avatar_preview_cache_busts_not_asset_version - after upload the rendered <img> is no longer keyed by asset_version (?v=test).

just test and just test-saas both green.

Out of scope (noted in LC-347)

Inline form errors for the wrong-format / over-1-MiB cases (currently a full-page styled error), and the shared static-asset_version cache-buster on other avatar render sites (sidebar self, message author rows).

Fixes LC-347. ## Problem Uploading a profile picture at `/settings` gave no signal it worked: no success message, and the avatar preview looked unchanged, so it read as a failure even though the upload succeeded server-side. ## Root causes (both confirmed in code) 1. **No success feedback.** `routes::settings::post_profile` redirected to `/settings` instead of `/settings?saved=1`, so the existing "Saved." flash (used by `post_language` / `post_appearance`) never fired. 2. **Stale preview.** The preview `<img src="/avatars/{id}?v={asset_version}">` was keyed by `asset_version`, a build-time constant that never changes on upload, while `routes::avatar::get_avatar` serves `Cache-Control: max-age=300`. The browser kept showing the cached old image for up to five minutes. ## Fix - `post_profile` redirects to `/settings?saved=1`. - The preview is cache-busted by the avatar file's mtime (new `avatar_cache_key` helper, surfaced as `UserSettingsPage.avatar_version`), so the new image loads immediately. ## Tests New `server/tests/routes_settings_profile.rs`: - `avatar_upload_redirects_to_saved_flash` - POST multipart avatar returns 303 to `/settings?saved=1` and persists `avatar_ext`. - `settings_avatar_preview_cache_busts_not_asset_version` - after upload the rendered `<img>` is no longer keyed by `asset_version` (`?v=test`). `just test` and `just test-saas` both green. ## Out of scope (noted in LC-347) Inline form errors for the wrong-format / over-1-MiB cases (currently a full-page styled error), and the shared static-`asset_version` cache-buster on other avatar render sites (sidebar self, message author rows).

longjacksonle added 3 commits 2026-06-19 04:20:54 +02:00

fix(settings): confirm profile-picture upload and refresh the preview (LC-347) ... e573216643

Uploading a profile picture gave no signal that it worked: no success message, and the avatar preview appeared unchanged, so it read as a failure even though the upload succeeded.

Two causes. First, `post_profile` redirected to `/settings` rather than `/settings?saved=1`, so the existing "Saved." flash (used by `post_language` / `post_appearance`) never fired. Second, the preview `<img src="/avatars/{id}?v={asset_version}">` was keyed by `asset_version`, a build-time constant that never changes on upload, while the avatar route serves `Cache-Control: max-age=300`; the browser therefore showed the cached old image for up to five minutes.

`post_profile` now redirects to `/settings?saved=1`, and the preview is cache-busted by the avatar file's mtime (new `avatar_cache_key` helper, surfaced as `UserSettingsPage.avatar_version`) so the new image loads immediately. Adds `routes_settings_profile.rs` covering the `?saved=1` redirect and that the preview URL is no longer keyed by `asset_version`.

Out of scope (noted in LC-347): inline form errors for the wrong-format / over-1-MiB cases, and the shared static-`asset_version` cache-buster on other avatar render sites (sidebar self, message rows).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

chore: drop accidental .claude/scheduled_tasks.lock change from LC-347 7beca2ae98

Merge remote-tracking branch 'origin/main' into fix/lc-347-avatar-upload-feedback 797916bf44

longjacksonle merged commit 1d41ca8169 into main 2026-06-19 04:21:43 +02:00

longjacksonle deleted branch fix/lc-347-avatar-upload-feedback 2026-06-19 04:21:44 +02:00

longjacksonle referenced this pull request from a commit 2026-06-19 04:21:45 +02:00

Merge pull request 'fix(settings): confirm profile-picture upload and refresh the preview (LC-347)' (#365) from fix/lc-347-avatar-upload-feedback into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

psa-systems/lets-chat!365

No description provided.