fix(ci): drop save --force from publish-release manifest write #104

Merged

David merged 1 commit from fix/publish-release-no-save-force into main

2026-05-15 02:21:59 +02:00

David commented

2026-05-15 02:08:54 +02:00

Owner

Summary

Removes a stray save --force from .forgejo/workflows/publish-release.yml (introduced in #103) that violates the project's no-force-flags rule. Plain save already creates the file; the --force is only meaningful when artifacts/latest.json already exists from an earlier step in the same job, which never happens because the workflow checks out a fresh tree. Hitting the failure path on an unexpected pre-existing file is the desired behaviour - it would surface a real bug in the build steps above.

One-line diff inside the Generate update manifest step.

Test plan

grep -n -- '--force\|-rf' .forgejo/workflows/ returns no hits inside this repo's workflow tree after the change.
On the next v* tag push, the Generate update manifest step still emits artifacts/latest.json and the workflow proceeds into the upload step (will be verified on the next release).

## Summary Removes a stray `save --force` from `.forgejo/workflows/publish-release.yml` (introduced in #103) that violates the project's no-force-flags rule. Plain `save` already creates the file; the `--force` is only meaningful when `artifacts/latest.json` already exists from an earlier step in the same job, which never happens because the workflow checks out a fresh tree. Hitting the failure path on an unexpected pre-existing file is the desired behaviour - it would surface a real bug in the build steps above. One-line diff inside the `Generate update manifest` step. ## Test plan - [x] `grep -n -- '--force\|-rf' .forgejo/workflows/` returns no hits inside this repo's workflow tree after the change. - [ ] On the next `v*` tag push, the `Generate update manifest` step still emits `artifacts/latest.json` and the workflow proceeds into the upload step (will be verified on the next release).

David added 1 commit

2026-05-15 02:08:54 +02:00

fix(ci): drop save --force from publish-release manifest write

Check / clippy + fmt + tests (pull_request) Failing after 27s

Details

01c7daeecc

Plain `save` already creates the file; a `--force` flag is only needed when an artifacts/latest.json already exists from a prior step in the same run, which never happens here because the workflow checks out a fresh tree. Hitting the failure path on an unexpected pre-existing file is the desired behaviour - it would surface a real bug in the build steps above. Matches the project's no-force-flags rule.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>