psa-systems/bunyip
Watch
9
0
Fork
You've already forked bunyip
 0
Code Issues Pull requests 1 Projects Releases 18 Packages Wiki Activity Actions 1

fix(api): initialize recurring_interval_count in the admin price fixture #518

Closed
Claude-Run wants to merge 1 commit from chore/checks-workflow-443da76c into main
pull from: chore/checks-workflow-443da76c
merge into: psa-systems:main
Conversation 1 Commits 1 Files changed 1 +2
Claude-Run commented 2026-08-12 05:37:43 +02:00
Member
Copy link

The BUNYIP-517 test helper in bunyip-api/src/handlers/admin.rs built a StripePriceResponse literal while, on a parallel branch, the dunite-stripe bump added the recurring_interval_count field to that shared DTO. Both merged cleanly on their own, so main broke on a semantic conflict: cargo test --workspace --all-targets fails with error[E0063]: missing field recurring_interval_count in initializer of bunyip_domain::models::StripePriceResponse (check.yml run #3005 at 443da76c). The sibling fixture in handlers/pricing.rs had already been updated, so only this one site was stale.

Add the field to the fixture with Some(1), matching the monthly price the helper already describes and the value the pricing.rs fixture uses. Test-only change; no production behaviour moves. Every remaining struct-literal site of the DTO (pricing.rs:522, admin.rs:3547) now initializes it, and rustc's E0063 is itself the mechanical guard against a third site regressing.

#BUNYIP-522

The BUNYIP-517 test helper in `bunyip-api/src/handlers/admin.rs` built a `StripePriceResponse` literal while, on a parallel branch, the dunite-stripe bump added the `recurring_interval_count` field to that shared DTO. Both merged cleanly on their own, so `main` broke on a semantic conflict: `cargo test --workspace --all-targets` fails with `error[E0063]: missing field recurring_interval_count in initializer of bunyip_domain::models::StripePriceResponse` (check.yml run #3005 at 443da76c). The sibling fixture in `handlers/pricing.rs` had already been updated, so only this one site was stale. Add the field to the fixture with `Some(1)`, matching the monthly price the helper already describes and the value the pricing.rs fixture uses. Test-only change; no production behaviour moves. Every remaining struct-literal site of the DTO (pricing.rs:522, admin.rs:3547) now initializes it, and rustc's E0063 is itself the mechanical guard against a third site regressing. #BUNYIP-522
fix(api): initialize recurring_interval_count in the admin price fixture
All checks were successful
E2E / PR gate (pull_request) Successful in 24s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
Check / fmt + clippy + build + tests (pull_request) Successful in 9m51s
Details
6f796bb467 
The BUNYIP-517 test helper in `bunyip-api/src/handlers/admin.rs` built a `StripePriceResponse` literal while, on a parallel branch, the dunite-stripe bump added the `recurring_interval_count` field to that shared DTO. Both merged cleanly on their own, so `main` broke on a semantic conflict: `cargo test --workspace --all-targets` fails with `error[E0063]: missing field recurring_interval_count in initializer of bunyip_domain::models::StripePriceResponse` (check.yml run #3005 at 443da76c). The sibling fixture in `handlers/pricing.rs` had already been updated, so only this one site was stale.

Add the field to the fixture with `Some(1)`, matching the monthly price the helper already describes and the value the pricing.rs fixture uses. Test-only change; no production behaviour moves. Every remaining struct-literal site of the DTO (pricing.rs:522, admin.rs:3547) now initializes it, and rustc's E0063 is itself the mechanical guard against a third site regressing.

#BUNYIP-522
longjacksonle commented 2026-08-12 05:44:09 +02:00
Owner
Copy link

Closing as redundant: the identical fix already landed on main via PR #514 (BUNYIP-516, merge c099489), which carried recurring_interval_count: Some(1) in this same handlers/admin.rs price fixture. main already compiles its tests (the E0063 is resolved), and this branch's only change is the same one line, which is why it now shows a duplicate-change conflict. Nothing left to merge.

Closing as redundant: the identical fix already landed on main via PR #514 (BUNYIP-516, merge c099489), which carried `recurring_interval_count: Some(1)` in this same `handlers/admin.rs` price fixture. main already compiles its tests (the E0063 is resolved), and this branch's only change is the same one line, which is why it now shows a duplicate-change conflict. Nothing left to merge.
longjacksonle closed this pull request 2026-08-12 05:44:09 +02:00
All checks were successful
E2E / PR gate (pull_request) Successful in 24s
Required
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
Check / fmt + clippy + build + tests (pull_request) Successful in 9m51s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/bunyip!518
No description provided.