refactor(observability): consume dunite-core error-log + client-IP #495

Merged

nrupard merged 1 commit from feat/DEV-529-consume-observability into main

2026-08-06 18:03:20 +02:00

nrupard commented

2026-08-06 17:39:54 +02:00

Owner

What

Consumes dunite-core's error-log ring + trusted-proxy client-IP (dunite #39, DEV-529) and removes bunyip's copies.

error_log.rs -> a re-export shim over dunite_core::error_log (ErrorLogBuffer / ErrorLogLayer / ErrorLogEntry / DEFAULT_CAPACITY). The main.rs tracing wiring and the admin log view are unchanged.
middleware/auth.rs: extract_client_ip keeps its thin wrapper (it reads bunyip's trusted-proxy config via trusted_proxies) but delegates to dunite_core::middleware::client_ip. The local resolve_client_ip and its four unit tests are removed (the parity tests live in dunite-core). The ~30 crate::middleware::extract_client_ip call sites are unchanged.

Pins

Bumps the dunite-core graph (core/download/oci/oidc) 90a828f -> 82f9baa (dunite-core gains error_log + client_ip; download/oci/oidc are unchanged). The leaf pins stay put, so this does not cross the dunite-user-core MembershipTier rename.

Validation

just check-container green: cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace --all-targets.

#DEV-529

## What Consumes dunite-core's error-log ring + trusted-proxy client-IP (dunite #39, DEV-529) and removes bunyip's copies. - `error_log.rs` -> a re-export shim over `dunite_core::error_log` (`ErrorLogBuffer` / `ErrorLogLayer` / `ErrorLogEntry` / `DEFAULT_CAPACITY`). The `main.rs` tracing wiring and the admin log view are unchanged. - `middleware/auth.rs`: `extract_client_ip` keeps its thin wrapper (it reads bunyip's trusted-proxy config via `trusted_proxies`) but delegates to `dunite_core::middleware::client_ip`. The local `resolve_client_ip` and its four unit tests are removed (the parity tests live in dunite-core). The ~30 `crate::middleware::extract_client_ip` call sites are unchanged. ## Pins Bumps the dunite-core graph (core/download/oci/oidc) `90a828f` -> `82f9baa` (dunite-core gains error_log + client_ip; download/oci/oidc are unchanged). The leaf pins stay put, so this does not cross the `dunite-user-core` `MembershipTier` rename. ## Validation `just check-container` green: `cargo fmt --all --check`, `cargo clippy --workspace --all-targets -- -D warnings`, `cargo test --workspace --all-targets`. #DEV-529

nrupard added 1 commit

2026-08-06 17:39:54 +02:00

refactor(observability): consume dunite-core error-log + client-IP

E2E / PR gate (pull_request) Successful in 28s

Details

Check / fmt + clippy + build + tests (pull_request) Successful in 23m23s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

4c022dbaea

The error-log ring and the trusted-proxy client-IP resolver moved to dunite-core (dunite #39, DEV-529).

error_log.rs is now a re-export shim over dunite_core::error_log; the main.rs tracing wiring and the admin log view are unchanged. middleware/auth.rs keeps the thin extract_client_ip wrapper (it supplies bunyip's trusted-proxy config) but delegates to dunite_core::middleware::client_ip; the local resolve_client_ip and its four unit tests are removed, and the ~30 extract_client_ip call sites are unchanged.

Bumps the dunite-core graph (core/download/oci/oidc) 90a828f -> 82f9baa; dunite-core gains error_log + client_ip while download/oci/oidc are unchanged. The leaf pins stay put, so this does not cross the dunite-user-core MembershipTier rename.

#DEV-529

nrupard scheduled this pull request to auto merge when all checks succeed

2026-08-06 17:46:22 +02:00