feat(admin): flex the remaining single-column settings screens (BUNYIP-435) #434

Merged

longjacksonle merged 1 commit from feat/BUNYIP-435-admin-settings-flex-layout into main

2026-08-02 02:08:42 +02:00

longjacksonle commented

2026-08-02 02:03:54 +02:00

Owner

Finishes the BUNYIP-415 sweep: moves the audited remaining single-narrow-column admin settings screens onto the shared two-column block layout (layout::admin_block inside layout::admin_block_grid: two columns at lg, one column below), so every settings screen fills the available width and collapses cleanly at narrow viewports. No second layout pattern is introduced (AC3).

Audit (AC1, also recorded on the issue before converting)

Converted, each a single narrow fixed-width column or sparse stacked cards:

Applications create/edit form (application_form): the max-w-md column becomes Details | Distribution blocks in one form, so a single Save still persists everything. On create the Identity fields lead as a full-width block (absent when editing). This is the "application settings page" from the 2026-07-31 standup recollection.
Application Groups create/edit form (group_form): the max-w-md column becomes Identity | Presentation blocks.
Seed Data: Export and Import stop being two sparse full-width cards stacked vertically and flow into the two-column block grid, top-aligned.

Audited and deliberately left alone, because they already fill the width (this corrects the uncertain recollection that audit logs / error logs / users were missed): Audit Logs, Error Logs, the Users / Applications / Groups list screens, and the User detail page are full-width row lists or full-width card stacks, not narrow columns. Splitting their dense rows into two columns would squeeze the metadata and risk the horizontal overflow AC5 forbids. The Feedback list overflow is the separate BUNYIP-414.

details_fields drops its now-redundant inner "Details" heading (the block title carries it); it is single-use, so no other caller is affected.

Verification

application_form_uses_two_column_blocks and group_form_uses_two_column_blocks assert the responsive lg:grid-cols-2 grid, the block titles, that the max-w-md cap is gone, and that every field survives the regroup.
Each converted page was screenshotted at 1440px (two columns filling the width, no dead band) and 560px (a clean single-column collapse, no horizontal overflow), covering AC4 and AC5.
just check-container green (fmt + clippy -D warnings + workspace tests).

Acceptance criteria

Admin settings screens audited and the list of unconverted pages recorded on the issue.
All identified pages use the same block layout as Email / Entitlements.
No second layout pattern introduced.
Each converted page verified at a narrow viewport and collapsing to one column.
No horizontal overflow introduced on any converted page.

🤖 Generated with Claude Code

https://claude.ai/code/session_018TXaT3P192nDsZzbzHETb9

Finishes the BUNYIP-415 sweep: moves the audited remaining single-narrow-column admin settings screens onto the shared two-column block layout (`layout::admin_block` inside `layout::admin_block_grid`: two columns at `lg`, one column below), so every settings screen fills the available width and collapses cleanly at narrow viewports. No second layout pattern is introduced (AC3). ## Audit (AC1, also recorded on the issue before converting) Converted, each a single narrow fixed-width column or sparse stacked cards: - **Applications create/edit form** (`application_form`): the `max-w-md` column becomes **Details | Distribution** blocks in one form, so a single Save still persists everything. On create the Identity fields lead as a full-width block (absent when editing). This is the "application settings page" from the 2026-07-31 standup recollection. - **Application Groups create/edit form** (`group_form`): the `max-w-md` column becomes **Identity | Presentation** blocks. - **Seed Data**: Export and Import stop being two sparse full-width cards stacked vertically and flow into the two-column block grid, top-aligned. Audited and deliberately left alone, because they already fill the width (this corrects the uncertain recollection that audit logs / error logs / users were missed): **Audit Logs, Error Logs**, the **Users / Applications / Groups list** screens, and the **User detail** page are full-width row lists or full-width card stacks, not narrow columns. Splitting their dense rows into two columns would squeeze the metadata and risk the horizontal overflow AC5 forbids. The Feedback list overflow is the separate **BUNYIP-414**. `details_fields` drops its now-redundant inner "Details" heading (the block title carries it); it is single-use, so no other caller is affected. ## Verification - `application_form_uses_two_column_blocks` and `group_form_uses_two_column_blocks` assert the responsive `lg:grid-cols-2` grid, the block titles, that the `max-w-md` cap is gone, and that every field survives the regroup. - Each converted page was screenshotted at **1440px** (two columns filling the width, no dead band) and **560px** (a clean single-column collapse, no horizontal overflow), covering AC4 and AC5. - `just check-container` green (fmt + clippy `-D warnings` + workspace tests). ## Acceptance criteria - [x] Admin settings screens audited and the list of unconverted pages recorded on the issue. - [x] All identified pages use the same block layout as Email / Entitlements. - [x] No second layout pattern introduced. - [x] Each converted page verified at a narrow viewport and collapsing to one column. - [x] No horizontal overflow introduced on any converted page. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_018TXaT3P192nDsZzbzHETb9

longjacksonle added 1 commit

2026-08-02 02:03:54 +02:00

feat(admin): flex the remaining single-column settings screens (BUNYIP-435)

E2E PR gate / Install + reachability (no deployment secrets) (pull_request) Successful in 23s

Details

Check / fmt + clippy + build + tests (pull_request) Successful in 4m46s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

d0a5979bac

Several admin settings screens still rendered as one narrow fixed-width column with a wide band of dead space to the right, the inconsistency BUNYIP-415 started fixing. This finishes the sweep by moving the audited remainder onto the same shared block layout (layout::admin_block inside layout::admin_block_grid: two columns at lg, one column below), so no second layout pattern is introduced.

Audit result (recorded on the issue before converting). Converted, because each was a single narrow fixed-width column or a set of sparse stacked cards:
- Applications create/edit form (application_form): the max-w-md column becomes Details | Distribution blocks in one form, so a single Save still persists everything. On create the Identity fields lead as a full-width block (absent when editing). This is the "application settings page" from the 2026-07-31 standup recollection.
- Application Groups create/edit form (group_form): the max-w-md column becomes Identity | Presentation blocks.
- Seed Data: Export and Import stop being two sparse full-width cards stacked vertically and flow into the two-column block grid, top-aligned.

Audited and deliberately left alone, because they already fill the width (this corrects the uncertain recollection that audit logs / error logs / users were missed): Audit Logs, Error Logs, the Users / Applications / Groups list screens, and the User detail page are full-width row lists or full-width card stacks, not narrow columns. Splitting their dense rows into two columns would squeeze the metadata and risk the horizontal overflow the ticket forbids. The Feedback list overflow is the separate BUNYIP-414.

details_fields drops its now-redundant inner "Details" heading (the block title carries it); it is single-use so no other caller is affected.

Tests (bunyip-web): application_form_uses_two_column_blocks and group_form_uses_two_column_blocks assert the responsive lg:grid-cols-2 grid, the block titles, that the max-w-md cap is gone, and that every field survives the regroup. Each converted page was also screenshotted at 1440px (two columns filling the width) and 560px (a clean single-column collapse with no horizontal overflow). just check-container is green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018TXaT3P192nDsZzbzHETb9

longjacksonle scheduled this pull request to auto merge when all checks succeed

2026-08-02 02:04:45 +02:00