psa-systems/bunyip
Watch
9
0
Fork
You've already forked bunyip
 0
Code Issues Pull requests Projects Releases 18 Packages Wiki Activity Actions

fix(web): OCI sign-in step is always required, not "only if private" (BUNYIP-393) #386

Merged
nrupard merged 1 commit from fix/BUNYIP-393-oci-login-always-required into main 2026-07-21 21:15:43 +02:00
Conversation 0 Commits 1 Files changed 1 +3 -2
nrupard commented 2026-07-21 21:11:52 +02:00
Owner
Copy link

Bug

The container-image pull instructions told users to sign in to the registry "only if it is private". But the registry is a private proxy - authentication with a8n.systems credentials is always required - so the qualifier misled users into skipping docker login.

Fix

bunyip-web/src/handlers/dashboard.rs, container_instructions:

  • Step label: "Sign in to the registry (only if it is private)" -> "Sign in to the registry".
  • The helper's doc comment: dropped "sign in if the registry is private", noting the registry is a private proxy so sign-in is always required.

The step now reads as unconditional. Build + fmt green. One file, +3/-2.

## Bug The container-image pull instructions told users to sign in to the registry "only if it is private". But the registry is a private proxy - authentication with a8n.systems credentials is **always** required - so the qualifier misled users into skipping `docker login`. ## Fix `bunyip-web/src/handlers/dashboard.rs`, `container_instructions`: - Step label: "Sign in to the registry (only if it is private)" -> "Sign in to the registry". - The helper's doc comment: dropped "sign in if the registry is private", noting the registry is a private proxy so sign-in is always required. The step now reads as unconditional. Build + fmt green. One file, +3/-2.
fix(web): drop the "only if private" qualifier from the OCI sign-in step (BUNYIP-393)
All checks were successful
E2E / Playwright against deployment (pull_request) Successful in 29s
Details
Check / fmt + clippy + build + tests (pull_request) Successful in 3m49s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
3156dfc492 
The container-image pull instructions told users to sign in to the registry "only if it is private", but the registry is a private proxy - authentication with a8n.systems credentials is always required, and the qualifier misled users into skipping docker login. Remove the conditional from the step label ("Sign in to the registry") and from the helper's doc comment so the sign-in step reads as always required.

#BUNYIP-393

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nrupard scheduled this pull request to auto merge when all checks succeed 2026-07-21 21:14:16 +02:00
nrupard deleted branch fix/BUNYIP-393-oci-login-always-required 2026-07-21 21:15:44 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/bunyip!386
No description provided.