psa-systems/bunyip
Watch
9
0
Fork
You've already forked bunyip
 0
Code Issues Pull requests Projects Releases 18 Packages Wiki Activity Actions

fix(consent): render the OIDC consent page through the public auth shell (BUNYIP-223) #253

Merged
YousifShkara merged 1 commit from fix/BUNYIP-223-consent-page-styled-shell into main 2026-06-26 09:14:08 +02:00
Conversation 0 Commits 1 Files changed 1 +15 -15
YousifShkara commented 2026-06-26 08:52:05 +02:00
Owner
Copy link

A first-time mokosh sign-in triggers /oauth2/consent for the profile scope. The page was rendered via render_html(card), the bare-Markup-to-Response helper, instead of auth_page which wraps the public shell (head + stylesheet link + brand chrome). Without the stylesheet, the auth_card's shield SVG ships at the browser default size (~500px tall), the bullet list ignores its Tailwind classes, and the Allow / Deny buttons land naked in the corner. Functionally the flow worked; presentationally it looked like a broken page right at the user's most visually-loaded moment with the product.

Switch consent_get to auth_page so the consent screen renders inside the same shell as /login, /register, /magic-link, and the verify-email landing. Move the "An application is requesting access" copy into the auth_card subtitle slot where it visually belongs, and replace the manual "·" glyph + flex row with a normal list-disc list so the bullet is the real list bullet not a typographic character. No change to consent_post or the underlying scope-grant API.

#BUNYIP-223

A first-time mokosh sign-in triggers /oauth2/consent for the profile scope. The page was rendered via render_html(card), the bare-Markup-to-Response helper, instead of auth_page which wraps the public shell (head + stylesheet link + brand chrome). Without the stylesheet, the auth_card's shield SVG ships at the browser default size (~500px tall), the bullet list ignores its Tailwind classes, and the Allow / Deny buttons land naked in the corner. Functionally the flow worked; presentationally it looked like a broken page right at the user's most visually-loaded moment with the product. Switch consent_get to auth_page so the consent screen renders inside the same shell as /login, /register, /magic-link, and the verify-email landing. Move the "An application is requesting access" copy into the auth_card subtitle slot where it visually belongs, and replace the manual "·" glyph + flex row with a normal list-disc list so the bullet is the real list bullet not a typographic character. No change to consent_post or the underlying scope-grant API. #BUNYIP-223
fix(consent): render the OIDC consent page through the public auth shell (BUNYIP-223)
All checks were successful
E2E / Playwright against deployment (pull_request) Successful in 36s
Details
Check / fmt + clippy + build + tests (pull_request) Successful in 9m36s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
34184d7c95 
A first-time mokosh sign-in triggers /oauth2/consent for the profile scope. The page was rendered via render_html(card), the bare-Markup-to-Response helper, instead of auth_page which wraps the public shell (head + stylesheet link + brand chrome). Without the stylesheet, the auth_card's shield SVG ships at the browser default size (~500px tall), the bullet list ignores its Tailwind classes, and the Allow / Deny buttons land naked in the corner. Functionally the flow worked; presentationally it looked like a broken page right at the user's most visually-loaded moment with the product.

Switch consent_get to auth_page so the consent screen renders inside the same shell as /login, /register, /magic-link, and the verify-email landing. Move the "An application is requesting access" copy into the auth_card subtitle slot where it visually belongs, and replace the manual "·" glyph + flex row with a normal list-disc list so the bullet is the real list bullet not a typographic character. No change to consent_post or the underlying scope-grant API.

#BUNYIP-223
YousifShkara deleted branch fix/BUNYIP-223-consent-page-styled-shell 2026-06-26 09:14:08 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/bunyip!253
No description provided.