chore(e2e): remove BUNYIP-167 diagnostics + make blockLiveReload work via addInitScript (BUNYIP-168) #192

Merged

nrupard merged 1 commit from chore/BUNYIP-167-remove-temp-diagnostics into main

2026-06-22 21:50:50 +02:00

nrupard commented

2026-06-22 21:43:10 +02:00

Owner

Removes the temporary BUNYIP-167 diagnostics (resolved-config dump + /login wire logger) now that the root cause is found.\n\nFixes blockLiveReload: page.route("**/v1/events", abort) did NOT stop the reload (Playwright does not reliably intercept an EventSource), so the SSE subscriber still reloaded /login and wiped the form (empty POST -> false "incorrect"). Switch to page.addInitScript("window.EventSource = undefined") - bunyip-webs SSE subscriber bails when EventSource is absent, so the reload never arms; addInitScript runs before page scripts on every navigation.\n\nfillVerified kept as a loud guard. tsc clean; 18 specs collect.\n\nThe server-side fix is BUNYIP-169.\n\n#BUNYIP-168

Removes the temporary BUNYIP-167 diagnostics (resolved-config dump + /login wire logger) now that the root cause is found.\n\nFixes blockLiveReload: `page.route("**/v1/events", abort)` did NOT stop the reload (Playwright does not reliably intercept an EventSource), so the SSE subscriber still reloaded /login and wiped the form (empty POST -> false "incorrect"). Switch to `page.addInitScript("window.EventSource = undefined")` - bunyip-webs SSE subscriber bails when EventSource is absent, so the reload never arms; addInitScript runs before page scripts on every navigation.\n\nfillVerified kept as a loud guard. tsc clean; 18 specs collect.\n\nThe server-side fix is BUNYIP-169.\n\n#BUNYIP-168

nrupard added 1 commit

2026-06-22 21:43:10 +02:00

chore(e2e): remove BUNYIP-167 diagnostics + make blockLiveReload actually work

E2E / Playwright against deployment (pull_request) Failing after 21s

Details

Check / fmt + clippy + build + tests (pull_request) Successful in 2m6s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

94ad872c70

Removes the temporary BUNYIP-167 diagnostics now that the root cause is found: the resolved-config dump (logResolvedConfig + fingerprint in lib/env.ts, the preflight call) and the /login wire logger (attachLoginWireDiagnostics + fp in lib/login.ts).

Fixes blockLiveReload: the previous `page.route('**/v1/events', abort)` did NOT stop the reload (Playwright does not reliably intercept an EventSource), so the SSE subscriber still reloaded the login page and wiped the form (the POST kept going out empty). Switch to `page.addInitScript('window.EventSource = undefined')`: bunyip-web's SSE subscriber bails when EventSource is absent (`if(!window.EventSource)return`), so the live-reload never arms. addInitScript runs before any page script on every navigation, so it covers the whole flow.

fillVerified stays as a loud guard against an empty POST. Comments updated to the real cause (SSE reload, BUNYIP-168; server-side fix tracked in BUNYIP-169) instead of the earlier htmx-re-render hypothesis.

tsc --noEmit clean; all 18 specs collect.

#BUNYIP-168

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>