fix(layout): restore floating feedback launcher, drop top-bar icon #105

Merged

YousifShkara merged 1 commit from fix/feedback-widget-restore-floating into main

2026-06-11 05:32:20 +02:00

YousifShkara commented

2026-06-11 05:32:17 +02:00

Owner

Closes BUNYIP-83.

PR #93 moved the feedback affordance from a floating bottom-right launcher to a small icon in the top bar to fix the audit finding that the launcher overlapped the Vervain Agent Download buttons on /downloads. In hands-on use the top-bar icon is too easy to miss; the hover-expand "Have feedback?" floating launcher was the desired UX. Restore it, and address the original overlap surgically by adding pb-24 to the Downloads page wrapper.

Changes:

bunyip-web/src/views/layout.rs: re-introduce feedback_launcher() with the original markup (fixed bottom-4 right-4, hover-expand). Delete feedback_top_button(...). Mount the launcher inside dashboard_shell (every authenticated dashboard page) and inside public_shell gated by the existing show_feedback flag (marketing pages on, auth pages off). Remove the top-bar icon mount from app_topbar. The show_feedback parameter on header() is retained for call-site stability; the underscore-prefix silences the unused-arg lint without changing signatures.
bunyip-web/src/handlers/dashboard.rs: Downloads page wrapper goes from space-y-6 to space-y-6 pb-24. Inline comment explains the launcher clearance. Other dashboard pages do not collide and stay untouched.

Admin pages still have no launcher (admin_shell never mounted it, before or after this change).

#BUNYIP-83

Closes BUNYIP-83. PR #93 moved the feedback affordance from a floating bottom-right launcher to a small icon in the top bar to fix the audit finding that the launcher overlapped the Vervain Agent Download buttons on `/downloads`. In hands-on use the top-bar icon is too easy to miss; the hover-expand "Have feedback?" floating launcher was the desired UX. Restore it, and address the original overlap surgically by adding `pb-24` to the Downloads page wrapper. Changes: - `bunyip-web/src/views/layout.rs`: re-introduce `feedback_launcher()` with the original markup (fixed `bottom-4 right-4`, hover-expand). Delete `feedback_top_button(...)`. Mount the launcher inside `dashboard_shell` (every authenticated dashboard page) and inside `public_shell` gated by the existing `show_feedback` flag (marketing pages on, auth pages off). Remove the top-bar icon mount from `app_topbar`. The `show_feedback` parameter on `header()` is retained for call-site stability; the underscore-prefix silences the unused-arg lint without changing signatures. - `bunyip-web/src/handlers/dashboard.rs`: Downloads page wrapper goes from `space-y-6` to `space-y-6 pb-24`. Inline comment explains the launcher clearance. Other dashboard pages do not collide and stay untouched. Admin pages still have no launcher (admin_shell never mounted it, before or after this change). #BUNYIP-83

YousifShkara self-assigned this

2026-06-11 05:32:17 +02:00

YousifShkara added 1 commit

2026-06-11 05:32:17 +02:00

fix(layout): restore floating feedback launcher, drop top-bar icon

Create release / Create release from merged PR (pull_request) Has been skipped

Details

Check / fmt / clippy / build / test (pull_request) Successful in 1m46s

Details

0655b6dda8

Closes BUNYIP-83.

PR #93 moved the feedback affordance from a floating bottom-right launcher to a small icon in the top bar to fix the audit finding that the launcher overlapped the Vervain Agent Download buttons on `/downloads`. In hands-on use the top-bar icon is too easy to miss; the hover-expand "Have feedback?" floating launcher was the desired UX. Restore it, and address the original overlap surgically by adding `pb-24` to the Downloads page wrapper.

Changes:

- `bunyip-web/src/views/layout.rs`: re-introduce `feedback_launcher()` with the original markup (fixed `bottom-4 right-4`, hover-expand). Delete `feedback_top_button(...)`. Mount the launcher inside `dashboard_shell` (every authenticated dashboard page) and inside `public_shell` gated by the existing `show_feedback` flag (marketing pages on, auth pages off). Remove the top-bar icon mount from `app_topbar`. The `show_feedback` parameter on `header()` is retained for call-site stability; the underscore-prefix silences the unused-arg lint without changing signatures.
- `bunyip-web/src/handlers/dashboard.rs`: Downloads page wrapper goes from `space-y-6` to `space-y-6 pb-24`. Inline comment explains the launcher clearance. Other dashboard pages do not collide and stay untouched.

Admin pages still have no launcher (admin_shell never mounted it, before or after this change).

#BUNYIP-83

YousifShkara merged commit d094513c75 into main

2026-06-11 05:32:20 +02:00

YousifShkara deleted branch fix/feedback-widget-restore-floating

2026-06-11 05:32:21 +02:00

YousifShkara referenced this pull request from a commit

2026-06-11 05:32:22 +02:00

Merge pull request 'fix(layout): restore floating feedback launcher, drop top-bar icon' (#105) from fix/feedback-widget-restore-floating into main