psa-systems/vervain-server
Watch
9
0
Fork
You've already forked vervain-server
 0
Code Issues Pull requests 1 Projects Releases 2 Packages Wiki Activity Actions

feat(server): resolve external_base_url from VERVAIN_BASE_URL env var (VS-55) #78

Merged
Claude-Run merged 1 commit from feat/VS-55-vervain-base-url-env into main 2026-06-26 15:58:29 +02:00
Conversation 0 Commits 1 Files changed 3 +124 -17
Claude-Run commented 2026-06-26 15:56:25 +02:00
Member
Copy link

read_external_base_url now consults a new VERVAIN_BASE_URL env var as a fallback after the config keys, so a config-less deployment mints agent-facing URLs against the public API host instead of falling back to wss://localhost. Precedence stays settings.cert > settings.external_base_url > VERVAIN_BASE_URL > None, so an explicit config.json still wins. The env value is a full URL with scheme; any trailing slash is trimmed defensively. Threaded the env lookup as an injectable closure (mirrors parse_setup_overrides) so the precedence chain is unit-tested. Documented the var in .env.example and the README settings table.

#VS-55

read_external_base_url now consults a new VERVAIN_BASE_URL env var as a fallback after the config keys, so a config-less deployment mints agent-facing URLs against the public API host instead of falling back to wss://localhost. Precedence stays settings.cert > settings.external_base_url > VERVAIN_BASE_URL > None, so an explicit config.json still wins. The env value is a full URL with scheme; any trailing slash is trimmed defensively. Threaded the env lookup as an injectable closure (mirrors parse_setup_overrides) so the precedence chain is unit-tested. Documented the var in .env.example and the README settings table. #VS-55
feat(server): resolve external_base_url from VERVAIN_BASE_URL env var (VS-55)
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 1m52s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
706b12af4d 
read_external_base_url now consults a new VERVAIN_BASE_URL env var as a fallback after the config keys, so a config-less deployment mints agent-facing URLs against the public API host instead of falling back to wss://localhost. Precedence stays settings.cert > settings.external_base_url > VERVAIN_BASE_URL > None, so an explicit config.json still wins. The env value is a full URL with scheme; any trailing slash is trimmed defensively. Threaded the env lookup as an injectable closure (mirrors parse_setup_overrides) so the precedence chain is unit-tested. Documented the var in .env.example and the README settings table.

#VS-55
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-server!78
No description provided.