psa-systems/vervain-server
Watch
9
0
Fork
You've already forked vervain-server
 0
Code Issues Pull requests 1 Projects Releases 2 Packages Wiki Activity Actions

docs(plugins): refresh stale Stub doc comments on lifecycle variants (VS-5) #25

Merged
David merged 2 commits from feat/plugin-lifecycle-vs-5 into main 2026-05-17 14:33:27 +02:00
Conversation 0 Commits 2 Files changed 1 +14 -7
David commented 2026-05-17 04:56:20 +02:00
Owner
Copy link

Summary

All five plugin-lifecycle handlers (addplugin / installplugin / disableplugin / removeplugin / reloadplugin) are wired against real implementations under crates/meshcentral-web/src/plugin_lifecycle.rs. The ControlIn serde doc comments still labelled them as stubs, which leaked into the ROADMAP refresh and got refiled as VS-5.

This PR just refreshes the docs so the next ROADMAP scan does not refile them.

Test plan

  • cargo check -p meshcentral-web clean.
  • Reviewer: add a plugin via the SPA's admin panel + walk through install / disable / reload / remove.

Closes VS-5.

## Summary All five plugin-lifecycle handlers (`addplugin` / `installplugin` / `disableplugin` / `removeplugin` / `reloadplugin`) are wired against real implementations under `crates/meshcentral-web/src/plugin_lifecycle.rs`. The `ControlIn` serde doc comments still labelled them as stubs, which leaked into the ROADMAP refresh and got refiled as VS-5. This PR just refreshes the docs so the next ROADMAP scan does not refile them. ## Test plan - [x] `cargo check -p meshcentral-web` clean. - [ ] Reviewer: add a plugin via the SPA's admin panel + walk through install / disable / reload / remove. Closes VS-5.
docs(plugins): refresh stale Stub doc comments on lifecycle ControlIn variants (VS-5)
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 1m38s
Details
46be8a5c39 
The five plugin-lifecycle ControlIn variants (addplugin / installplugin / disableplugin / removeplugin / reloadplugin) are all wired against real `plugin_lifecycle::*` handlers (see `user_session.rs:2783-2950`). The serde doc comments still labelled them as stubs; ROADMAP filed VS-5 off that.

No behavior change. Docs now mention `plugin_lifecycle::add_from_manifest` (for addplugin), `plugin_lifecycle::install` (installplugin), `plugin_lifecycle::set_status` (disable + reload), and `plugin_lifecycle::remove` so future ROADMAP scans don't refile.

#VS-5 State Done
Merge branch 'main' into feat/plugin-lifecycle-vs-5
Some checks failed
Create release / Create release from merged PR (pull_request) Has been skipped
Details
Check / fmt + clippy + build + tests (pull_request) Failing after 18s
Details
ce10b49e45
David merged commit a224b7ecbe into main 2026-05-17 14:33:27 +02:00
David deleted branch feat/plugin-lifecycle-vs-5 2026-05-17 14:33:27 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-server!25
No description provided.