docs(user-session): refresh stale GetSysInfo/PowerTimeline/UpdateAgents doc comments (VS-9, VS-10) #17

Merged
David merged 2 commits from feat/sysinfo-cache-vs-10 into main 2026-05-17 14:37:08 +02:00
Owner

Summary

VS-9 and VS-10 (and the inline UpdateAgents reference on the ROADMAP) were filed off stale serde doc comments on ControlIn::GetSysInfo / GetNetworkInfo / PowerTimeline / UpdateAgents. The handlers themselves are real:

  • GetSysInfo / GetNetworkInfo: cache hit serves the latest msg/sysinfo reply captured by agent.rs::dispatch_text (line 583+); cache miss pokes the agent so the next refresh paints, returns noinfo:true this round (user_session.rs:4039-4112).
  • PowerTimeline: reads power_events (populated by agent connect/disconnect) and compacts via power_events::compact_timeline (user_session.rs:4113-4128).
  • UpdateAgents: signs and pushes an oobupdate frame per matching connected agent (user_session.rs:7577+).

This PR just refreshes the four doc comments so future readers (and future ROADMAP refreshes) don't refile the same ghosts.

Test plan

  • cargo check -p meshcentral-web clean.
  • Reviewer: confirm the live SPA actually paints the Information + Network + power-timeline tabs against a connected agent.

Closes VS-9, VS-10.

## Summary VS-9 and VS-10 (and the inline UpdateAgents reference on the ROADMAP) were filed off stale serde doc comments on `ControlIn::GetSysInfo` / `GetNetworkInfo` / `PowerTimeline` / `UpdateAgents`. The handlers themselves are real: - `GetSysInfo` / `GetNetworkInfo`: cache hit serves the latest `msg/sysinfo` reply captured by `agent.rs::dispatch_text` (line 583+); cache miss pokes the agent so the next refresh paints, returns `noinfo:true` this round (`user_session.rs:4039-4112`). - `PowerTimeline`: reads `power_events` (populated by agent connect/disconnect) and compacts via `power_events::compact_timeline` (`user_session.rs:4113-4128`). - `UpdateAgents`: signs and pushes an `oobupdate` frame per matching connected agent (`user_session.rs:7577+`). This PR just refreshes the four doc comments so future readers (and future ROADMAP refreshes) don't refile the same ghosts. ## Test plan - [x] `cargo check -p meshcentral-web` clean. - [ ] Reviewer: confirm the live SPA actually paints the Information + Network + power-timeline tabs against a connected agent. Closes VS-9, VS-10.
docs(user-session): refresh stale GetSysInfo/GetNetworkInfo/PowerTimeline/UpdateAgents comments (VS-10, VS-9)
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 4m51s
a175cbca59
The dispatch arms for `getsysinfo`, `getnetworkinfo`, `powertimeline`, and `updateAgents` are all real handlers (see `user_session.rs:4039-4112`, `:4113-4128`, and the `update_agents_push` helper), but the `ControlIn` enum's serde doc comments still claimed they were stubs returning `noinfo:true` / empty / `not-implemented`. The stale text leaked into ROADMAP.md and got refiled as VS-9, VS-10, and (in the same area) the UpdateAgents row.

Updates the four doc comments to describe what the code actually does today: cache hit serves the latest `msg/sysinfo` snapshot captured by `agent.rs::dispatch_text`; cache miss pokes the agent and returns `noinfo:true` for the current round. PowerTimeline compacts `power_events` rows; UpdateAgents signs and pushes an `oobupdate` frame per connected agent.

No behavior change.

#VS-9 State Done
#VS-10 State Done
Merge branch 'main' into feat/sysinfo-cache-vs-10
Some checks failed
Create release / Create release from merged PR (pull_request) Has been skipped
Check / fmt + clippy + build + tests (pull_request) Failing after 13s
639c2f1c01
David merged commit 85fb159ef7 into main 2026-05-17 14:37:08 +02:00
David deleted branch feat/sysinfo-cache-vs-10 2026-05-17 14:37:08 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-server!17
No description provided.