psa-systems/vervain-apps
Watch
9
0
Fork
You've already forked vervain-apps
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

feat(desktop): clearly labeled Close connection control in ribbon #72

Merged
Claude-Run merged 1 commit from feat/VAPP-57-desktop-close-connection-ribbon into main 2026-07-01 02:50:44 +02:00
Conversation 0 Commits 1 Files changed 1 +11 -2
Claude-Run commented 2026-07-01 02:49:40 +02:00
Member
Copy link

The remote-desktop card header already serves as the top ribbon, hosting the VAPP-52 viewport modes (Fit/Full size/Scaled) and the session controls (Quality, Capture, Detach, Refresh). Its disconnect control read only "Close", which is ambiguous (close the pane vs. close the connection) and visually indistinct from the other buttons.

Relabel it "Close connection", give it the danger styling, and add a tooltip so the ribbon carries an obvious, deliberate in-app disconnect. Behavior is unchanged: it calls on_close, which unmounts the pane and lets use_drop close the WebSocket so the agent stops capturing, tearing the session down cleanly.

#VAPP-57

The remote-desktop card header already serves as the top ribbon, hosting the VAPP-52 viewport modes (Fit/Full size/Scaled) and the session controls (Quality, Capture, Detach, Refresh). Its disconnect control read only "Close", which is ambiguous (close the pane vs. close the connection) and visually indistinct from the other buttons. Relabel it "Close connection", give it the danger styling, and add a tooltip so the ribbon carries an obvious, deliberate in-app disconnect. Behavior is unchanged: it calls on_close, which unmounts the pane and lets use_drop close the WebSocket so the agent stops capturing, tearing the session down cleanly. #VAPP-57
feat(desktop): clearly labeled Close connection control in ribbon
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 57s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
c3dd66cead 
The remote-desktop card header already serves as the top ribbon, hosting the VAPP-52 viewport modes (Fit/Full size/Scaled) and the session controls (Quality, Capture, Detach, Refresh). Its disconnect control read only "Close", which is ambiguous (close the pane vs. close the connection) and visually indistinct from the other buttons.

Relabel it "Close connection", give it the danger styling, and add a tooltip so the ribbon carries an obvious, deliberate in-app disconnect. Behavior is unchanged: it calls on_close, which unmounts the pane and lets use_drop close the WebSocket so the agent stops capturing, tearing the session down cleanly.

#VAPP-57
David deleted branch feat/VAPP-57-desktop-close-connection-ribbon 2026-07-02 03:42:44 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-apps!72
No description provided.