fix(desktop): silence wasm dead_code warning on DesktopServerConfig #71

Merged
Claude-Run merged 2 commits from feat/VAPP-58-desktop-server-url-prompt into main 2026-07-01 02:45:19 +02:00
Member

On the wasm client build the server fn is a network stub and the only readers of the struct's fields are desktop-gated UI, so the fields are flagged unread. Mark the model allow(dead_code) with a note explaining why.

#VAPP-58

On the wasm client build the server fn is a network stub and the only readers of the struct's fields are desktop-gated UI, so the fields are flagged unread. Mark the model allow(dead_code) with a note explaining why. #VAPP-58
The desktop build resolves its vervain-server URL at startup in order (VAPP-58, extending VAPP-54): a build-time baked value first, then the value the user persisted, then a first-run prompt. A branded hosted build sets VERVAIN_BAKED_SERVER_URL at compile time (read via option_env!), which pre-configures the server, suppresses the first-run prompt on the login screen, and renders the Settings "Server URL" read-only. The generic self-hosted build leaves it unset: the login screen shows the first-run prompt only when no URL is resolved yet, persists the entered value, and reuses it on later launches.

Adds a Clear control alongside Save in the server-URL editor so a self-hosted user can drop the persisted URL and point the app at a different instance without reinstalling. Baked builds reject both set and clear server-side. internal_base_url/public_base_url now fall back to the resolved URL (baked, then persisted) so the baked value feeds auth and every request.

#VAPP-58
fix(desktop): silence wasm dead_code warning on DesktopServerConfig
All checks were successful
Check / fmt + clippy + build + tests (pull_request) Successful in 35s
Create release / Create release from merged PR (pull_request) Has been skipped
385f651656
On the wasm client build the server fn is a network stub and the only readers of the struct's fields are desktop-gated UI, so the fields are flagged unread. Mark the model allow(dead_code) with a note explaining why.

#VAPP-58
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-apps!71
No description provided.