fix(release): restore VA-92 keep-debuginfo comment #141

Merged
longjacksonle merged 1 commit from fix/restore-release-profile-comment into main 2026-07-15 04:37:51 +02:00

Restores the [profile.release] documentation comment (VA-92) that the v0.4.0 release recipe silently dropped.

just create-release bumps the version by piping Cargo.toml through nushell's to toml, which does not preserve comments. When v0.4.0 was cut, that roundtrip deleted the six-line block explaining why the release binary retains line-table debuginfo and the ELF symbol table (a stripped release once reduced a SIGBUS core to a single unresolvable frame; keeping line tables plus .symtab lets both a captured core and the in-process fault handler resolve file:line).

The [profile.release] keys (debug = "line-tables-only", etc.) were never changed, so this is a documentation-only restore with no effect on the produced binary.

Follow-up worth tracking separately: the recipe's to toml step will strip this comment again on the next release. The recipe should do a surgical version-line edit instead of a full TOML reserialization.

Restores the `[profile.release]` documentation comment (VA-92) that the v0.4.0 release recipe silently dropped. `just create-release` bumps the version by piping `Cargo.toml` through nushell's `to toml`, which does not preserve comments. When v0.4.0 was cut, that roundtrip deleted the six-line block explaining why the release binary retains line-table debuginfo and the ELF symbol table (a stripped release once reduced a SIGBUS core to a single unresolvable frame; keeping line tables plus `.symtab` lets both a captured core and the in-process fault handler resolve `file:line`). The `[profile.release]` keys (`debug = "line-tables-only"`, etc.) were never changed, so this is a documentation-only restore with no effect on the produced binary. Follow-up worth tracking separately: the recipe's `to toml` step will strip this comment again on the next release. The recipe should do a surgical version-line edit instead of a full TOML reserialization.
fix(release): restore VA-92 keep-debuginfo comment stripped by release recipe
All checks were successful
Check / fmt + clippy + tests (pull_request) Successful in 5m41s
Create release / Create release from merged PR (pull_request) Has been skipped
e53c9354d6
The v0.4.0 release bump ran Cargo.toml through the create-release recipe's nushell `to toml` roundtrip, which drops comments, silently deleting the block above `[profile.release]` that documents why the release binary keeps line tables and the symbol table (VA-92: a stripped release reduced a SIGBUS core to one unresolvable frame). The `[profile.release]` settings themselves were unchanged, so this restores documentation only, no binary behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
longjacksonle deleted branch fix/restore-release-profile-comment 2026-07-15 04:37:52 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/vervain-agent!141
No description provided.