fix(ci): treat empty E2E_BASE_URL as missing, not as override #94

Merged

nrupard merged 1 commit from fix/e2e-runner-toolcache into main

2026-06-05 16:35:40 +02:00

nrupard commented

2026-06-05 16:33:41 +02:00

Owner

Forgejo Actions resolves an unset secret to the literal empty string rather than to undefined, so process.env.E2E_BASE_URL ?? default did not fall back when the secret was not configured. wait-for-deploy.mjs then built a relative /api/v1/version URL and node's fetch refused it with "Failed to parse URL". Playwright's baseURL had the same bug latent.

Replace ?? with explicit empty/whitespace checks in both spots so the documented https://msp.a8n.systems default actually applies when the secret is missing.

#PMS-140

Forgejo Actions resolves an unset secret to the literal empty string rather than to undefined, so `process.env.E2E_BASE_URL ?? default` did not fall back when the secret was not configured. wait-for-deploy.mjs then built a relative `/api/v1/version` URL and node's fetch refused it with "Failed to parse URL". Playwright's baseURL had the same bug latent. Replace `??` with explicit empty/whitespace checks in both spots so the documented `https://msp.a8n.systems` default actually applies when the secret is missing. #PMS-140

nrupard added 1 commit

2026-06-05 16:33:41 +02:00

fix(ci): treat empty E2E_BASE_URL as missing, not as override

Check / fmt + clippy + compile + tests (pull_request) Successful in 1m34s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

0de61637c0

Forgejo Actions resolves an unset secret to the literal empty string rather than to undefined, so `process.env.E2E_BASE_URL ?? default` did not fall back when the secret was not configured. wait-for-deploy.mjs then built a relative `/api/v1/version` URL and node's fetch refused it with "Failed to parse URL". Playwright's baseURL had the same bug latent.

Replace `??` with explicit empty/whitespace checks in both spots so the documented `https://msp.a8n.systems` default actually applies when the secret is missing.

#PMS-140