psa-systems/mokosh-server
Watch
9
0
Fork
You've already forked mokosh-server
 1
Code Issues Pull requests Projects Releases 10 Packages Wiki Activity Actions

test(e2e): un-fixme form-validation now that MAPPS-347 SPA fix has merged #422

Merged
YousifShkara merged 1 commit from test/MAPPS-347-unfixme-form-validation into main 2026-07-03 12:55:31 +02:00
Conversation 0 Commits 1 Files changed 1 +10 -9
YousifShkara commented 2026-07-02 11:12:04 +02:00
Owner
Copy link

mokosh-apps 39872ab (merged as PR #410) restored the Input component's inline-error rendering path: the always-installed onmounted + onkeydown handlers dfb12cb added were reverted, and GlobalSearch's autofocus + Escape moved to a parent-div keydown + a use_effect focus so the shared Input surface stays untouched. That closes the SPA-side regression MAPPS-347 quarantined this spec against; drop the test.fixme and rely on staging picking up the new SPA build.

If this red-lights again after the un-fixme, refile a fresh ticket rather than restoring the quarantine - the SPA fix is a specific revert, not a "monitor for months" bet.

#MAPPS-347

mokosh-apps 39872ab (merged as PR #410) restored the Input component's inline-error rendering path: the always-installed `onmounted` + `onkeydown` handlers dfb12cb added were reverted, and GlobalSearch's autofocus + Escape moved to a parent-div keydown + a use_effect focus so the shared Input surface stays untouched. That closes the SPA-side regression MAPPS-347 quarantined this spec against; drop the `test.fixme` and rely on staging picking up the new SPA build. If this red-lights again after the un-fixme, refile a fresh ticket rather than restoring the quarantine - the SPA fix is a specific revert, not a "monitor for months" bet. #MAPPS-347
YousifShkara force-pushed test/MAPPS-347-unfixme-form-validation from 043247fa24
Some checks failed
Check / fmt + clippy + build + tests (pull_request) Successful in 2m6s
Details
E2E / Playwright against staging (pull_request) Failing after 9s
Details
Integration / integration tests (pull_request) Successful in 7m12s
Details
to c1b50fdacc
All checks were successful
E2E / Playwright against staging (pull_request) Successful in 33s
Details
Check / fmt + clippy + build + tests (pull_request) Successful in 1m24s
Details
Integration / integration tests (pull_request) Successful in 5m30s
Details
Create release / Gate (release-branch merges only) (pull_request) Successful in 1s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
2026-07-03 12:42:56 +02:00 Compare
YousifShkara deleted branch test/MAPPS-347-unfixme-form-validation 2026-07-03 12:55:31 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-server!422
No description provided.