psa-systems/mokosh-server
Watch
9
0
Fork
You've already forked mokosh-server
 1
Code Issues Pull requests Projects Releases 10 Packages Wiki Activity Actions

feat(tickets): derive Serialize+Deserialize on all ticket DTOs #396

Closed
David wants to merge 0 commits from dev-yousif into main
pull from: dev-yousif
merge into: psa-systems:main
Conversation 0 Commits - Files changed 582 +9 -9
David commented 2026-06-28 22:35:52 +02:00
Owner
Copy link

Adds Serialize on the request DTOs (CreateTicketRequest, UpdateTicketRequest, CreateNoteRequest, TicketFilter) and Deserialize on the response DTOs (TicketResponse, TicketStatusSummary, TicketPrioritySummary, TicketNoteResponse, TicketAttachmentResponse) so the byte-identical client copy of this module can both consume responses and post bodies typed against the shared structs. Server never deserialises its own responses or serialises requests, so the extra impls are unused on this side but the round-trip parity is what the client repo's drift CI guards against.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

Adds Serialize on the request DTOs (CreateTicketRequest, UpdateTicketRequest, CreateNoteRequest, TicketFilter) and Deserialize on the response DTOs (TicketResponse, TicketStatusSummary, TicketPrioritySummary, TicketNoteResponse, TicketAttachmentResponse) so the byte-identical client copy of this module can both consume responses and post bodies typed against the shared structs. Server never deserialises its own responses or serialises requests, so the extra impls are unused on this side but the round-trip parity is what the client repo's drift CI guards against. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
feat(tickets): derive Serialize+Deserialize on all ticket DTOs
All checks were successful
Check / fmt + clippy + compile + tests (pull_request) Successful in 1m0s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
2653c401fb 
Adds Serialize on the request DTOs (CreateTicketRequest, UpdateTicketRequest, CreateNoteRequest, TicketFilter) and Deserialize on the response DTOs (TicketResponse, TicketStatusSummary, TicketPrioritySummary, TicketNoteResponse, TicketAttachmentResponse) so the byte-identical client copy of this module can both consume responses and post bodies typed against the shared structs. Server never deserialises its own responses or serialises requests, so the extra impls are unused on this side but the round-trip parity is what the client repo's drift CI guards against.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
David closed this pull request 2026-06-28 22:39:48 +02:00
David deleted branch dev-yousif 2026-06-28 22:39:52 +02:00
Some checks are pending
Check / fmt + clippy + compile + tests (pull_request) Successful in 1m0s
Required
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
E2E / * (pull_request)
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-server!396
No description provided.